fix #92582: Bug: doctor falsely warns local memory embeddings are not ready (#95393)

mikasa0818 · vincentkoc · web-flow · commit ce0142f04e4c · 2026-06-24T10:04:12.000+08:00
* fix(doctor): ignore skipped local embedding probe

* fix(doctor): keep skipped local model diagnostics

---------

Co-authored-by: Vincent Koc &lt;25068+vincentkoc@users.noreply.github.com&gt;
diff --git a/src/commands/doctor-memory-search.test.ts b/src/commands/doctor-memory-search.test.ts
@@ -237,6 +237,47 @@ describe("noteMemorySearchHealth", () => {
     expect(note).not.toHaveBeenCalled();
   });
 
+  it("does not warn when local provider readiness probe was intentionally skipped", async () => {
+    resolveMemorySearchConfig.mockReturnValue({
+      provider: "local",
+      local: { modelPath: "hf:some-org/some-model-GGUF/model.gguf" },
+      remote: {},
+    });
+
+    await noteMemorySearchHealth(cfg, {
+      gatewayMemoryProbe: {
+        checked: false,
+        ready: false,
+        error:
+          "memory embedding readiness not checked; run `openclaw memory status --deep` to probe",
+        skipped: true,
+      },
+    });
+
+    expect(note).not.toHaveBeenCalled();
+  });
+
+  it("warns when local provider skipped readiness but configured local model is missing", async () => {
+    resolveMemorySearchConfig.mockReturnValue({
+      provider: "local",
+      local: { modelPath: "/definitely/missing/openclaw-memory-model.gguf" },
+      remote: {},
+    });
+
+    await noteMemorySearchHealth(cfg, {
+      gatewayMemoryProbe: {
+        checked: false,
+        ready: false,
+        error:
+          "memory embedding readiness not checked; run `openclaw memory status --deep` to probe",
+        skipped: true,
+      },
+    });
+
+    expect(note).toHaveBeenCalledTimes(1);
+    expect(firstNoteMessage()).toContain('Memory search provider is set to "local"');
+  });
+
   it("warns when local provider readiness probe is inconclusive", async () => {
     resolveMemorySearchConfig.mockReturnValue({
       provider: "local",
diff --git a/src/commands/doctor-memory-search.ts b/src/commands/doctor-memory-search.ts
@@ -473,6 +473,11 @@ export async function noteMemorySearchHealth(
       return;
     }
     const hasExplicitLocalModel = hasLocalEmbeddings(resolved.local);
+    const hasUnavailableConfiguredLocalModel =
+      Boolean(normalizeOptionalString(resolved.local.modelPath)) && !hasExplicitLocalModel;
+    if (opts?.gatewayMemoryProbe?.skipped && !hasUnavailableConfiguredLocalModel) {
+      return;
+    }
     const detail = opts?.gatewayMemoryProbe?.error?.trim();
     note(
       [

Original file line number	Diff line number	Diff line change
`@@ -473,6 +473,11 @@ export async function noteMemorySearchHealth(`
`473`	`473`	`return;`
`474`	`474`	`}`
`475`	`475`	`const hasExplicitLocalModel = hasLocalEmbeddings(resolved.local);`
	`476`	`+ const hasUnavailableConfiguredLocalModel =`
	`477`	`+ Boolean(normalizeOptionalString(resolved.local.modelPath)) && !hasExplicitLocalModel;`
	`478`	`+ if (opts?.gatewayMemoryProbe?.skipped && !hasUnavailableConfiguredLocalModel) {`
	`479`	`+ return;`
	`480`	`+ }`
`476`	`481`	`const detail = opts?.gatewayMemoryProbe?.error?.trim();`
`477`	`482`	`note(`
`478`	`483`	`[`