fix(install): repair stale Winget Node registrations

ooiuuii · ooiuuii · commit cc8e5cc319aa · 2026-07-21T11:48:35.000+08:00
diff --git a/scripts/install.ps1 b/scripts/install.ps1
@@ -521,6 +521,7 @@ function Install-Node {
     if (Get-Command winget -ErrorAction SilentlyContinue) {
         Write-Host "  Using winget..." -ForegroundColor Gray
         winget install OpenJS.NodeJS.LTS --source winget --accept-package-agreements --accept-source-agreements | Out-Host
+        $wingetExitCode = $LASTEXITCODE
 
         # Refresh PATH
         Refresh-ProcessPath
@@ -529,6 +530,16 @@ function Install-Node {
             Write-Host "[OK] Node.js installed via winget" -ForegroundColor Green
             return $true
         }
+        if ($wingetExitCode -eq -1978335189) {
+            Write-Host "[!] winget found a stale Node.js registration; retrying with --force" -ForegroundColor Yellow
+            winget install OpenJS.NodeJS.LTS --source winget --force --accept-package-agreements --accept-source-agreements | Out-Host
+            Refresh-ProcessPath
+            Add-InstalledNodeToProcessPath | Out-Null
+            if (Check-Node) {
+                Write-Host "[OK] Node.js repaired via winget" -ForegroundColor Green
+                return $true
+            }
+        }
         Write-Host "[!] winget completed, but Node.js is still unavailable in this shell" -ForegroundColor Yellow
         Write-Host "Restart PowerShell and re-run the installer if Node.js was installed successfully." -ForegroundColor Yellow
         return $false
diff --git a/test/scripts/install-ps1.test.ts b/test/scripts/install-ps1.test.ts
@@ -341,6 +341,40 @@ describe("install.ps1 failure handling", () => {
           "",
         ].join("\n"),
       },
+      {
+        name: "winget-stale-node-registration",
+        source: [
+          scriptWithoutEntryPoint,
+          "",
+          "function Get-Command {",
+          "  [CmdletBinding()]",
+          "  param([string]$Name)",
+          "  if ($Name -eq 'winget') { return $true }",
+          "  return $null",
+          "}",
+          "filter Out-Host { }",
+          "function Refresh-ProcessPath { }",
+          "function Add-InstalledNodeToProcessPath { return $false }",
+          "$script:wingetCalls = @()",
+          "function winget {",
+          "  $script:wingetCalls += ($args -join ' ')",
+          "  if ($script:wingetCalls.Count -eq 1) {",
+          "    $global:LASTEXITCODE = -1978335189",
+          "  } else {",
+          "    $global:LASTEXITCODE = 0",
+          "  }",
+          "  Write-Output 'winget output'",
+          "}",
+          "function Check-Node { return ($script:wingetCalls.Count -ge 2) }",
+          "$result = @(Install-Node)",
+          'if ($result.Count -ne 1 -or $result[0] -ne $true) { throw "Install-Node returned $result" }',
+          "if ($script:wingetCalls.Count -ne 2) { throw \"Calls=$($script:wingetCalls -join '|')\" }",
+          "if ($script:wingetCalls[1] -ne 'install OpenJS.NodeJS.LTS --source winget --force --accept-package-agreements --accept-source-agreements') {",
+          '  throw "ForceCall=$($script:wingetCalls[1])"',
+          "}",
+          "",
+        ].join("\n"),
+      },
       {
         name: "chocolatey-node-upgrade",
         source: [
@@ -601,6 +635,7 @@ describe("install.ps1 failure handling", () => {
 
   runIfPowerShell("upgrades and validates Node installed by Windows package managers", () => {
     expectBatchedPowerShellCase("winget-node-delayed-path");
+    expectBatchedPowerShellCase("winget-stale-node-registration");
     expectBatchedPowerShellCase("chocolatey-node-upgrade");
     expectBatchedPowerShellCase("scoop-node-update");
     expectBatchedPowerShellCase("package-manager-node-validation-failure");
