fix: respect disabled persisted plugin registry reads

steipete · steipete · commit cc4375fa62ee · 2026-06-01T01:41:51.000+01:00
diff --git a/src/plugins/plugin-registry-snapshot.ts b/src/plugins/plugin-registry-snapshot.ts
@@ -136,6 +136,16 @@ function resolvePluginRegistrySnapshotMemoKey(
   if (!canMemoizePluginRegistrySnapshot(params)) {
     return undefined;
   }
+  const persistedReadsEnabled =
+    params.preferPersisted !== false && !hasEnvFlag(env, DISABLE_PERSISTED_PLUGIN_REGISTRY_ENV);
+  const persistedRegistryFingerprint = persistedReadsEnabled
+    ? hashJson(
+        readPersistedInstalledPluginIndexSync({
+          env,
+          ...(params.stateDir ? { stateDir: params.stateDir } : {}),
+        }),
+      )
+    : "disabled";
   return hashJson({
     config: params.config ?? null,
     cwd: process.cwd(),
@@ -144,12 +154,7 @@ function resolvePluginRegistrySnapshotMemoKey(
     preferPersisted: params.preferPersisted ?? null,
     // Plugin manifests are process-stable inside the Gateway, while the persisted
     // registry envelope can change through explicit refresh/install flows.
-    registry: hashJson(
-      readPersistedInstalledPluginIndexSync({
-        env,
-        ...(params.stateDir ? { stateDir: params.stateDir } : {}),
-      }),
-    ),
+    registry: persistedRegistryFingerprint,
     pluginRoots: fingerprintPluginSourceRoots(params, env),
     stateDir: params.stateDir ? resolveUserPath(params.stateDir, env) : null,
     workspaceDir: params.workspaceDir ? resolveUserPath(params.workspaceDir, env) : null,
@@ -440,7 +445,7 @@ export function loadPluginRegistrySnapshotWithMetadata(
   const disabledByCaller = params.preferPersisted === false;
   const disabledByEnv = hasEnvFlag(env, DISABLE_PERSISTED_PLUGIN_REGISTRY_ENV);
   const persistedReadsEnabled = !disabledByCaller && !disabledByEnv;
-  const persistedInstallRecordReadsEnabled = !disabledByEnv;
+  const persistedInstallRecordReadsEnabled = persistedReadsEnabled;
   let persistedIndex: InstalledPluginIndex | null;
   if (persistedInstallRecordReadsEnabled) {
     persistedIndex = readPersistedInstalledPluginIndexSync(params);
diff --git a/src/plugins/plugin-registry.test.ts b/src/plugins/plugin-registry.test.ts
@@ -873,7 +873,7 @@ describe("plugin registry facade", () => {
     expectSnapshotPluginIds(result.snapshot, ["demo"]);
   });
 
-  it("derives a fresh registry without dropping persisted install records", async () => {
+  it("derives a fresh registry without persisted install records when caller disables persisted reads", async () => {
     const stateDir = makeTempDir();
     const rootDir = makeTempDir();
     const candidate = createCandidate(rootDir);
@@ -899,10 +899,7 @@ describe("plugin registry facade", () => {
 
     expect(result.source).toBe("derived");
     expectSnapshotPluginIds(result.snapshot, ["demo"]);
-    expectInstallRecord(result.snapshot.installRecords, "persisted", {
-      source: "npm",
-      spec: "persisted-plugin@1.0.0",
-    });
+    expect(result.snapshot.installRecords).not.toHaveProperty("persisted");
   });
 
   it("exposes explicit persisted registry inspect and refresh operations", async () => {
