fix(msteams): drop dangling surrogates in message previews

wangmiao0668000666 · wangmiao0668000666 · commit cb7a8b48f9ce · 2026-06-30T14:31:47.000+08:00
diff --git a/extensions/msteams/src/monitor-handler/message-handler.dm-media.test.ts b/extensions/msteams/src/monitor-handler/message-handler.dm-media.test.ts
@@ -1,5 +1,9 @@
 // Msteams tests cover message handlerm media plugin behavior.
 import { describe, expect, it } from "vitest";
+import {
+  sliceUtf16Safe,
+  truncateUtf16Safe,
+} from "openclaw/plugin-sdk/text-utility-runtime";
 import { translateMSTeamsDmConversationIdForGraph } from "../inbound.js";
 
 describe("translateMSTeamsDmConversationIdForGraph", () => {
@@ -53,3 +57,37 @@ describe("translateMSTeamsDmConversationIdForGraph", () => {
     expect(result).toBe("a:1abc2def3");
   });
 });
+
+// Verifies the three rawText / text / preview sites in message-handler.ts
+// (lines 250, 251, 505) drop a surrogate pair that straddles the truncation
+// boundary instead of leaving a lone high-surrogate half in the preview.
+describe("message-handler preview UTF-16 truncation", () => {
+  const emoji = "🎉";
+
+  it("truncateUtf16Safe drops a surrogate pair straddling the 50-char boundary (rawText path)", () => {
+    const input = "a".repeat(49) + emoji;
+    const out = truncateUtf16Safe(input, 50);
+    expect(out.length).toBe(49);
+    expect(out).toBe("a".repeat(49));
+    expect(out.charCodeAt(out.length - 1)).toBeLessThan(0xd800);
+  });
+
+  it("truncateUtf16Safe is a pass-through for plain ASCII (text path)", () => {
+    const input = "hello world";
+    expect(truncateUtf16Safe(input, 50)).toBe(input);
+  });
+
+  it("sliceUtf16Safe preserves an emoji that sits entirely before the 160-char cut (preview path)", () => {
+    const input = emoji + "a".repeat(160);
+    const out = sliceUtf16Safe(input, 0, 160);
+    expect(out.startsWith(emoji)).toBe(true);
+    expect(out.length).toBe(160);
+  });
+
+  it("sliceUtf16Safe drops a trailing surrogate straddling the 160-char cut (preview path)", () => {
+    const input = "a".repeat(159) + emoji;
+    const out = sliceUtf16Safe(input, 0, 160);
+    expect(out.length).toBe(159);
+    expect(out.charCodeAt(out.length - 1)).toBeLessThan(0xd800);
+  });
+});
diff --git a/extensions/msteams/src/monitor-handler/message-handler.ts b/extensions/msteams/src/monitor-handler/message-handler.ts
@@ -20,6 +20,10 @@ import {
   createChannelHistoryWindow,
   type HistoryEntry,
 } from "openclaw/plugin-sdk/reply-history";
+import {
+  sliceUtf16Safe,
+  truncateUtf16Safe,
+} from "openclaw/plugin-sdk/text-utility-runtime";
 import { serializeMSTeamsAdaptiveCardActionValue } from "../adaptive-card-submit.js";
 import {
   buildMSTeamsAttachmentPlaceholder,
@@ -248,8 +252,8 @@ export function createMSTeamsMessageHandler(deps: MSTeamsMessageHandlerDeps) {
     const htmlSummary = summarizeMSTeamsHtmlAttachments(attachments);
 
     log.info("received message", {
-      rawText: rawText.slice(0, 50),
-      text: text.slice(0, 50),
+      rawText: truncateUtf16Safe(rawText, 50),
+      text: truncateUtf16Safe(text, 50),
       attachments: attachments.length,
       attachmentTypes,
       from: from?.id,
@@ -503,7 +507,7 @@ export function createMSTeamsMessageHandler(deps: MSTeamsMessageHandlerDeps) {
       replyToId: activity.replyToId,
     });
 
-    const preview = rawBody.replace(/\s+/g, " ").slice(0, 160);
+    const preview = sliceUtf16Safe(rawBody.replace(/\s+/g, " "), 0, 160);
     const inboundLabel = isDirectMessage
       ? `Teams DM from ${senderName}`
       : `Teams message in ${conversationType} from ${senderName}`;
