fix(scripts): prebuild gateway cpu bench

vincentkoc · vincentkoc · commit ca70015a7ceb · 2026-05-25T04:24:01.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@ Docs: https://docs.openclaw.ai
 
 ### Fixes
 
+- Scripts: build CLI startup artifacts before the gateway CPU startup bench so fresh Linux runners do not report false `n/a` readiness and process metrics.
 - Scripts: remove stale Knip unused-file allowlist entries so the dead-code gate fails only on current findings.
 - Tests: normalize bundled plugin lifecycle probe paths and state-root lookup so native Windows release sweeps accept valid packaged plugin installs.
 - Config: keep benign legacy metadata write anomalies out of default doctor and config command output while preserving explicit anomaly logging for diagnostics.
diff --git a/scripts/check-gateway-cpu-scenarios.mjs b/scripts/check-gateway-cpu-scenarios.mjs
@@ -1,9 +1,10 @@
 #!/usr/bin/env node
 
-import { spawnSync } from "node:child_process";
+import { spawnSync as defaultSpawnSync } from "node:child_process";
 import fs from "node:fs";
 import path from "node:path";
 import process from "node:process";
+import { pathToFileURL } from "node:url";
 import { collectGatewayCpuObservations } from "./lib/plugin-gateway-gauntlet.mjs";
 import { createPnpmRunnerSpawnSpec } from "./pnpm-runner.mjs";
 
@@ -137,9 +138,10 @@ function readJsonIfExists(filePath) {
   return JSON.parse(fs.readFileSync(filePath, "utf8"));
 }
 
-function runStep(name, command, args, options = {}) {
+function runStep(name, command, args, options = {}, params = {}) {
   console.error(`[gateway-cpu] start ${name}`);
-  const result = spawnSync(command, args, {
+  const spawn = params.spawnSync ?? defaultSpawnSync;
+  const result = spawn(command, args, {
     cwd: process.cwd(),
     env: process.env,
     stdio: "inherit",
@@ -167,8 +169,7 @@ function toRepoRelativePath(absolutePath) {
   return relativePath;
 }
 
-async function main() {
-  const options = parseArgs(process.argv.slice(2));
+async function runGatewayCpuScenarios(options, params = {}) {
   fs.mkdirSync(options.outputDir, { recursive: true });
 
   const startupOutput = path.join(options.outputDir, "gateway-startup-bench.json");
@@ -177,19 +178,35 @@ async function main() {
   const steps = [];
 
   if (!options.skipStartup) {
+    const startupBuild = runStep(
+      "startup build",
+      process.execPath,
+      ["scripts/ensure-cli-startup-build.mjs"],
+      {},
+      params,
+    );
+    steps.push(startupBuild);
     steps.push(
-      runStep("startup bench", process.execPath, [
-        "--import",
-        "tsx",
-        "scripts/bench-gateway-startup.ts",
-        "--runs",
-        String(options.runs),
-        "--warmup",
-        String(options.warmup),
-        "--output",
-        startupOutput,
-        ...options.startupCases.flatMap((id) => ["--case", id]),
-      ]),
+      startupBuild.status === 0
+        ? runStep(
+            "startup bench",
+            process.execPath,
+            [
+              "--import",
+              "tsx",
+              "scripts/bench-gateway-startup.ts",
+              "--runs",
+              String(options.runs),
+              "--warmup",
+              String(options.warmup),
+              "--output",
+              startupOutput,
+              ...options.startupCases.flatMap((id) => ["--case", id]),
+            ],
+            {},
+            params,
+          )
+        : { name: "startup bench", signal: null, status: 1 },
     );
   }
 
@@ -207,7 +224,7 @@ async function main() {
       ...options.qaScenarios.flatMap((id) => ["--scenario", id]),
     ]);
     steps.push(
-      runStep("qa suite", qaCommand.command, qaCommand.args, qaCommand.options),
+      runStep("qa suite", qaCommand.command, qaCommand.args, qaCommand.options, params),
     );
   }
 
@@ -239,14 +256,30 @@ async function main() {
   };
   const summaryPath = path.join(options.outputDir, "summary.json");
   fs.writeFileSync(summaryPath, `${JSON.stringify(summary, null, 2)}\n`);
-  console.log(JSON.stringify(summary, null, 2));
+  if (!params.silent) {
+    console.log(JSON.stringify(summary, null, 2));
+  }
+
+  const exitCode = steps.some((step) => step.status !== 0) ? 1 : 0;
+  return { exitCode, summary };
+}
 
-  if (steps.some((step) => step.status !== 0)) {
+async function main(params = {}) {
+  const options = parseArgs(params.argv ?? process.argv.slice(2));
+  const result = await runGatewayCpuScenarios(options, params);
+  if (result.exitCode !== 0) {
     process.exitCode = 1;
   }
 }
 
-main().catch((error) => {
-  console.error(error instanceof Error ? error.stack : String(error));
-  process.exitCode = 1;
-});
+export const testing = {
+  parseArgs,
+  runGatewayCpuScenarios,
+};
+
+if (process.argv[1] && import.meta.url === pathToFileURL(process.argv[1]).href) {
+  main().catch((error) => {
+    console.error(error instanceof Error ? error.stack : String(error));
+    process.exitCode = 1;
+  });
+}
diff --git a/test/scripts/check-gateway-cpu-scenarios.test.ts b/test/scripts/check-gateway-cpu-scenarios.test.ts
@@ -0,0 +1,76 @@
+import { mkdirSync, mkdtempSync, rmSync } from "node:fs";
+import path from "node:path";
+import { afterEach, describe, expect, it } from "vitest";
+import { testing } from "../../scripts/check-gateway-cpu-scenarios.mjs";
+
+const tempRoots: string[] = [];
+
+function makeTempRoot(): string {
+  const artifactRoot = path.join(process.cwd(), ".artifacts");
+  mkdirSync(artifactRoot, { recursive: true });
+  const root = mkdtempSync(path.join(artifactRoot, "gateway-cpu-test-"));
+  tempRoots.push(root);
+  return root;
+}
+
+afterEach(() => {
+  for (const root of tempRoots.splice(0)) {
+    rmSync(root, { recursive: true, force: true });
+  }
+});
+
+describe("gateway CPU scenario guard", () => {
+  it("prepares CLI startup artifacts before running the startup bench", async () => {
+    const outputDir = makeTempRoot();
+    const calls: Array<{ command: string; args: string[] }> = [];
+    const options = testing.parseArgs([
+      "--output-dir",
+      outputDir,
+      "--runs",
+      "1",
+      "--warmup",
+      "0",
+      "--skip-qa",
+    ]);
+
+    const result = await testing.runGatewayCpuScenarios(options, {
+      silent: true,
+      spawnSync: (command: string, args: string[]) => {
+        calls.push({ command, args });
+        return { status: 0 };
+      },
+    });
+
+    expect(result.exitCode).toBe(0);
+    expect(calls.map((call) => call.args[0])).toEqual([
+      "scripts/ensure-cli-startup-build.mjs",
+      "--import",
+    ]);
+    expect(calls[1]?.args).toContain("scripts/bench-gateway-startup.ts");
+  });
+
+  it("does not run the startup bench when the startup build fails", async () => {
+    const outputDir = makeTempRoot();
+    const calls: string[][] = [];
+    const options = testing.parseArgs([
+      "--output-dir",
+      outputDir,
+      "--skip-qa",
+    ]);
+
+    const result = await testing.runGatewayCpuScenarios(options, {
+      silent: true,
+      spawnSync: (_command: string, args: string[]) => {
+        calls.push(args);
+        return { status: 1 };
+      },
+    });
+
+    expect(result.exitCode).toBe(1);
+    expect(calls).toEqual([["scripts/ensure-cli-startup-build.mjs"]]);
+    expect(result.summary.steps).toEqual([
+      { name: "startup build", signal: null, status: 1 },
+      { name: "startup bench", signal: null, status: 1 },
+    ]);
+  });
+});
