fix(message): return dry-run handledBy from executeSendAction

hclsys · hclsys · commit c9bee006a2b1 · 2026-05-11T12:09:48.000+08:00
`executeSendAction` always returned `handledBy: "core"` even when `dryRun` was true, so the dry-run branch in `formatMessageCliText` (which checks for `handledBy === "dry-run"`) was unreachable for `send` actions, causing the CLI to print the success message instead of the expected `[dry-run] would run send via <channel>` indicator. Return early with `handledBy: "dry-run"` when the context has `dryRun: true`, skipping both plugin dispatch and the actual send. Add `"dry-run"` to the `MessageActionRunResult` send-kind union so the type reflects the runtime behaviour. Fixes #80507
diff --git a/src/infra/outbound/message-action-runner.ts b/src/infra/outbound/message-action-runner.ts
@@ -126,7 +126,7 @@ export type MessageActionRunResult =
       channel: ChannelId;
       action: "send";
       to: string;
-      handledBy: "plugin" | "core";
+      handledBy: "plugin" | "core" | "dry-run";
       payload: unknown;
       toolResult?: AgentToolResult<unknown>;
       sendResult?: MessageSendResult;
diff --git a/src/infra/outbound/outbound-send-service.test.ts b/src/infra/outbound/outbound-send-service.test.ts
@@ -572,15 +572,16 @@ describe("executeSendAction", () => {
     });
   });
 
-  it("skips plugin dispatch during dry-run sends and forwards gateway + silent to sendMessage", async () => {
+  it("skips plugin dispatch during dry-run sends and returns dry-run handledBy", async () => {
     mocks.sendMessage.mockResolvedValue({
       channel: "demo-outbound",
       to: "channel:123",
       via: "gateway",
       mediaUrl: null,
+      dryRun: true,
     });
 
-    await executeSendAction({
+    const result = await executeSendAction({
       ctx: {
         cfg: {},
         channel: "demo-outbound",
@@ -611,6 +612,7 @@ describe("executeSendAction", () => {
       token: "tok",
       timeoutMs: 5000,
     });
+    expect(result.handledBy).toBe("dry-run");
   });
 
   it("routes prepared plugin send payloads through core best-effort delivery by default", async () => {
diff --git a/src/infra/outbound/outbound-send-service.ts b/src/infra/outbound/outbound-send-service.ts
@@ -244,7 +244,7 @@ export async function executeSendAction(params: {
   replyToId?: string;
   threadId?: string | number;
 }): Promise<{
-  handledBy: "plugin" | "core";
+  handledBy: "plugin" | "core" | "dry-run";
   payload: unknown;
   toolResult?: AgentToolResult<unknown>;
   sendResult?: MessageSendResult;
@@ -273,7 +273,7 @@ export async function executeSendAction(params: {
     });
 
     return {
-      handledBy: "core",
+      handledBy: result.dryRun ? "dry-run" : "core",
       payload: result,
       sendResult: result,
     };
@@ -312,7 +312,7 @@ export async function executeSendAction(params: {
   });
 
   return {
-    handledBy: "core",
+    handledBy: result.dryRun ? "dry-run" : "core",
     payload: result,
     sendResult: result,
   };
