fix(nextcloud-talk): cap room info cache size

Alix-007 · Alix-007 · commit c615207a9099 · 2026-07-07T20:37:58.000+08:00
diff --git a/extensions/nextcloud-talk/src/room-info.test.ts b/extensions/nextcloud-talk/src/room-info.test.ts
@@ -3,7 +3,7 @@ import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
 import path from "node:path";
 import { afterEach, describe, expect, it, vi } from "vitest";
-import { resolveNextcloudTalkRoomKind, testing } from "./room-info.js";
+import { ROOM_CACHE_MAX_ENTRIES, resolveNextcloudTalkRoomKind, testing } from "./room-info.js";
 
 const fetchWithSsrFGuard = vi.hoisted(() => vi.fn());
 const tempDirs: string[] = [];
@@ -79,6 +79,46 @@ describe("nextcloud talk room info", () => {
     expect(release).toHaveBeenCalledTimes(1);
   });
 
+  it("caps cached room info entries", async () => {
+    fetchWithSsrFGuard.mockImplementation(async () => ({
+      response: jsonResponse({
+        ocs: {
+          data: {
+            type: 1,
+          },
+        },
+      }),
+      release: vi.fn(async () => {}),
+    }));
+    const account = {
+      accountId: "acct-cache-cap",
+      baseUrl: "https://nc.example.com",
+      config: {
+        apiUser: "bot",
+        apiPassword: "secret",
+      },
+    } as never;
+
+    for (let index = 0; index <= ROOM_CACHE_MAX_ENTRIES; index += 1) {
+      await resolveNextcloudTalkRoomKind({
+        account,
+        roomToken: `room-${index}`,
+      });
+    }
+    await resolveNextcloudTalkRoomKind({ account, roomToken: "room-0" });
+    const callsAfterOldestRetry = fetchWithSsrFGuard.mock.calls.length;
+    await resolveNextcloudTalkRoomKind({
+      account,
+      roomToken: `room-${ROOM_CACHE_MAX_ENTRIES}`,
+    });
+
+    expect(callsAfterOldestRetry).toBe(ROOM_CACHE_MAX_ENTRIES + 2);
+    expect(fetchWithSsrFGuard.mock.calls).toHaveLength(callsAfterOldestRetry);
+    expect(fetchWithSsrFGuard.mock.calls.at(-1)?.[0]).toMatchObject({
+      url: "https://nc.example.com/ocs/v2.php/apps/spreed/api/v4/room/room-0",
+    });
+  });
+
   it("normalizes signed decimal room type strings through the shared parser", async () => {
     fetchWithSsrFGuard.mockResolvedValue({
       response: jsonResponse({
diff --git a/extensions/nextcloud-talk/src/room-info.ts b/extensions/nextcloud-talk/src/room-info.ts
@@ -9,6 +9,7 @@ import { resolveNextcloudTalkApiCredentials } from "./api-credentials.js";
 
 const ROOM_CACHE_TTL_MS = 5 * 60 * 1000;
 const ROOM_CACHE_ERROR_TTL_MS = 30 * 1000;
+export const ROOM_CACHE_MAX_ENTRIES = 1000;
 
 const roomCache = new Map<
   string,
@@ -25,6 +26,24 @@ function resolveRoomCacheKey(params: { accountId: string; roomToken: string }) {
   return `${params.accountId}:${params.roomToken}`;
 }
 
+function cacheRoomInfo(
+  key: string,
+  value: { kind?: "direct" | "group"; fetchedAt: number; error?: string },
+): void {
+  roomCache.set(key, value);
+  trimRoomCache();
+}
+
+function trimRoomCache(): void {
+  while (roomCache.size > ROOM_CACHE_MAX_ENTRIES) {
+    const oldestKey = roomCache.keys().next().value;
+    if (oldestKey === undefined) {
+      return;
+    }
+    roomCache.delete(oldestKey);
+  }
+}
+
 function coerceRoomType(value: unknown): number | undefined {
   if (typeof value === "number" && Number.isSafeInteger(value) && value > 0) {
     return value;
@@ -96,7 +115,7 @@ export async function resolveNextcloudTalkRoomKind(params: {
     });
     try {
       if (!response.ok) {
-        roomCache.set(key, {
+        cacheRoomInfo(key, {
           fetchedAt: Date.now(),
           error: `status:${response.status}`,
         });
@@ -111,13 +130,13 @@ export async function resolveNextcloudTalkRoomKind(params: {
       }>(response, "Nextcloud Talk room info failed");
       const type = coerceRoomType(payload.ocs?.data?.type);
       const kind = resolveRoomKindFromType(type);
-      roomCache.set(key, { fetchedAt: Date.now(), kind });
+      cacheRoomInfo(key, { fetchedAt: Date.now(), kind });
       return kind;
     } finally {
       await release();
     }
   } catch (err) {
-    roomCache.set(key, {
+    cacheRoomInfo(key, {
       fetchedAt: Date.now(),
       error: formatErrorMessage(err),
     });
