test: tighten hermes secret item assertions

shakkernerd · shakkernerd · commit c58ce5313815 · 2026-05-11T03:02:54.000+01:00
diff --git a/extensions/migrate-hermes/secrets.test.ts b/extensions/migrate-hermes/secrets.test.ts
@@ -45,15 +45,22 @@ describe("Hermes migration secret items", () => {
     );
 
     expect(plan.metadata?.agentDir).toBe(customAgentDir);
-    expect(plan.items).toEqual(
-      expect.arrayContaining([
-        expect.objectContaining({
-          id: "secret:openai",
-          target: `${customAgentDir}/auth-profiles.json#openai:hermes-import`,
-          status: "planned",
-        }),
-      ]),
-    );
+    expect(plan.items).toEqual([
+      {
+        id: "secret:openai",
+        kind: "secret",
+        action: "create",
+        source: path.join(source, ".env"),
+        target: `${customAgentDir}/auth-profiles.json#openai:hermes-import`,
+        status: "planned",
+        sensitive: true,
+        details: {
+          envVar: "OPENAI_API_KEY",
+          provider: "openai",
+          profileId: "openai:hermes-import",
+        },
+      },
+    ]);
 
     const result = await provider.apply(
       makeContext({
@@ -141,15 +148,23 @@ describe("Hermes migration secret items", () => {
 
     const result = await provider.apply(ctx, plan);
 
-    expect(result.items).toEqual(
-      expect.arrayContaining([
-        expect.objectContaining({
-          id: "secret:openai",
-          status: "conflict",
-          reason: HERMES_REASON_AUTH_PROFILE_EXISTS,
-        }),
-      ]),
-    );
+    expect(result.items).toEqual([
+      {
+        id: "secret:openai",
+        kind: "secret",
+        action: "create",
+        source: path.join(source, ".env"),
+        target: `${agentDir}/auth-profiles.json#openai:hermes-import`,
+        status: "conflict",
+        sensitive: true,
+        reason: HERMES_REASON_AUTH_PROFILE_EXISTS,
+        details: {
+          envVar: "OPENAI_API_KEY",
+          provider: "openai",
+          profileId: "openai:hermes-import",
+        },
+      },
+    ]);
     expect(result.summary.conflicts).toBe(1);
     const authStore = JSON.parse(
       await fs.readFile(path.join(agentDir, "auth-profiles.json"), "utf8"),
