fix(usage): guard malformed Z.ai usage payloads

Leon-SK668 · Leon-SK668 · commit c5073e3f81e4 · 2026-07-20T11:11:04.000+08:00
diff --git a/src/infra/provider-usage.fetch.zai.test.ts b/src/infra/provider-usage.fetch.zai.test.ts
@@ -20,6 +20,17 @@ describe("fetchZaiUsage", () => {
     expect(result.windows).toHaveLength(0);
   });
 
+  it.each([
+    ["null", null],
+    ["array", []],
+  ])("returns a stable API error for a successful %s payload", async (_name, payload) => {
+    const mockFetch = createProviderUsageFetch(async () => makeResponse(200, payload));
+    const result = await fetchZaiUsage("key", 5000, mockFetch);
+
+    expect(result.error).toBe("API error");
+    expect(result.windows).toHaveLength(0);
+  });
+
   it("returns API message errors for unsuccessful payloads", async () => {
     const mockFetch = createProviderUsageFetch(async () =>
       makeResponse(200, {
diff --git a/src/infra/provider-usage.fetch.zai.ts b/src/infra/provider-usage.fetch.zai.ts
@@ -1,4 +1,5 @@
 // Fetches and normalizes Z.ai provider usage records.
+import { isRecord } from "@openclaw/normalization-core/record-coerce";
 import {
   buildUsageHttpErrorSnapshot,
   discardUsageResponseBody,
@@ -56,9 +57,9 @@ export async function fetchZaiUsage(
   if (!parsed.ok) {
     return parsed.snapshot;
   }
-  const data = parsed.data as ZaiUsageResponse;
-  if (!data.success || data.code !== 200) {
-    const errorMessage = typeof data.msg === "string" ? data.msg.trim() : "";
+  const data = isRecord(parsed.data) ? (parsed.data as ZaiUsageResponse) : undefined;
+  if (!data || !data.success || data.code !== 200) {
+    const errorMessage = typeof data?.msg === "string" ? data.msg.trim() : "";
     return {
       provider: "zai",
       displayName: PROVIDER_LABELS.zai,
