fix(telegram): cool down transient sendChatAction failures

vincentkoc · vincentkoc · commit c4fe168624fc · 2026-04-28T07:43:07.000Z
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@ Docs: https://docs.openclaw.ai
 
 ### Fixes
 
+- Channels/Telegram: cool down transient `sendChatAction` network, rate-limit, and server failures without reclassifying broad message text, so typing indicators back off during Telegram outages while the shared typing guard still trips. Carries forward #55886; refs #55811, #55838, #56096, and #56153. Thanks @Boulea7, @sumaiazaman, and @Huangting-xy.
 - Control UI/WebChat: keep large attachment payloads out of Lit state and optimistic chat messages, using object URL previews plus send-time payload serialization so PDF/image uploads no longer trigger `RangeError: Maximum call stack size exceeded`. Fixes #73360; refs #54378 and #63432. Thanks @hejunhui-73, @Ansub, and @christianhernandez3-afk.
 - Agents/models: keep per-agent primary models strict when `fallbacks` is omitted, so probe-only custom providers are not tried as hidden fallback candidates unless the agent explicitly opts in. Fixes #73332. Thanks @haumanto.
 - Gateway/models: add `models.pricing.enabled` so offline or restricted-network installs can skip startup OpenRouter and LiteLLM pricing-catalog fetches while keeping explicit model costs working. Fixes #53639. Thanks @callebtc, @palewire, and @rjdjohnston.
diff --git a/extensions/telegram/src/network-errors.test.ts b/extensions/telegram/src/network-errors.test.ts
@@ -219,6 +219,16 @@ describe("isTelegramServerError", () => {
 });
 
 describe("isTelegramRateLimitError", () => {
+  class MockHttpError extends Error {
+    constructor(
+      message: string,
+      public readonly error: unknown,
+    ) {
+      super(message);
+      this.name = "HttpError";
+    }
+  }
+
   it.each([
     ["Too Many Requests", 429, true],
     ["Forbidden", 403, false],
@@ -231,6 +241,19 @@ describe("isTelegramRateLimitError", () => {
     const outer = Object.assign(new Error("wrapped"), { cause: inner });
     expect(isTelegramRateLimitError(outer)).toBe(true);
   });
+
+  it("detects structured grammY HttpError payloads", () => {
+    const wrapped = new MockHttpError("Too Many Requests", {
+      error_code: 429,
+      description: "Too Many Requests: retry after 5",
+      parameters: { retry_after: 5 },
+    });
+    expect(isTelegramRateLimitError(wrapped)).toBe(true);
+  });
+
+  it("does not infer rate limits from plain text", () => {
+    expect(isTelegramRateLimitError(new Error("429 Too Many Requests"))).toBe(false);
+  });
 });
 
 describe("isTelegramClientRejection", () => {
diff --git a/extensions/telegram/src/sendchataction-401-backoff.test.ts b/extensions/telegram/src/sendchataction-401-backoff.test.ts
@@ -34,6 +34,8 @@ describe("createTelegramSendChatActionHandler", () => {
   const make401Error = () => new Error("401 Unauthorized");
   const makeTransientNetworkError = () =>
     Object.assign(new Error("TypeError: fetch failed"), { code: "ETIMEDOUT" });
+  const makeBroadNetworkMessageError = () =>
+    new Error("Network request for 'sendChatAction' failed!");
   const makeRateLimitError = () => ({
     error_code: 429,
     message: "429 Too Many Requests",
@@ -200,6 +202,40 @@ describe("createTelegramSendChatActionHandler", () => {
     expect(logger).toHaveBeenCalledWith(expect.stringContaining("transient failure"));
   });
 
+  it("does not cool down broad network-message errors without structured network details", async () => {
+    const fn = vi.fn().mockRejectedValue(makeBroadNetworkMessageError());
+    const logger = vi.fn();
+    const { handler } = createHandler({
+      sendChatActionFn: fn,
+      logger,
+    });
+
+    await expect(handler.sendChatAction(123, "typing")).rejects.toThrow(
+      "Network request for 'sendChatAction' failed!",
+    );
+    await expect(handler.sendChatAction(123, "typing")).rejects.toThrow(
+      "Network request for 'sendChatAction' failed!",
+    );
+
+    expect(fn).toHaveBeenCalledTimes(2);
+    expect(logger).not.toHaveBeenCalledWith(expect.stringContaining("transient failure"));
+  });
+
+  it("keeps rejecting during transient cooldown so the typing start guard can trip", async () => {
+    const fn = vi.fn().mockRejectedValue(makeTransientNetworkError());
+    const logger = vi.fn();
+    const { handler } = createHandler({
+      sendChatActionFn: fn,
+      logger,
+    });
+
+    await expect(handler.sendChatAction(123, "typing")).rejects.toThrow("fetch failed");
+    await expect(handler.sendChatAction(123, "typing")).rejects.toThrow("fetch failed");
+
+    expect(fn).toHaveBeenCalledTimes(1);
+    expect(logger).toHaveBeenCalledTimes(1);
+  });
+
   it("treats Telegram 5xx responses as transient and does not suspend", async () => {
     const fn = vi.fn().mockRejectedValue(makeServerError());
     const logger = vi.fn();
diff --git a/extensions/telegram/src/sendchataction-401-backoff.ts b/extensions/telegram/src/sendchataction-401-backoff.ts
@@ -85,7 +85,7 @@ function is401Error(error: unknown): boolean {
 function isTransientSendChatActionError(error: unknown): boolean {
   return (
     isTelegramRateLimitError(error) ||
-    isRecoverableTelegramNetworkError(error, { context: "unknown", allowMessageMatch: true }) ||
+    isRecoverableTelegramNetworkError(error, { context: "send", allowMessageMatch: false }) ||
     isTelegramServerError(error)
   );
 }

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ function is401Error(error: unknown): boolean {`
`85`	`85`	`function isTransientSendChatActionError(error: unknown): boolean {`
`86`	`86`	`return (`
`87`	`87`	`isTelegramRateLimitError(error) \|\|`
`88`		`- isRecoverableTelegramNetworkError(error, { context: "unknown", allowMessageMatch: true }) \|\|`
	`88`	`+ isRecoverableTelegramNetworkError(error, { context: "send", allowMessageMatch: false }) \|\|`
`89`	`89`	`isTelegramServerError(error)`
`90`	`90`	`);`
`91`	`91`	`}`