refactor(plugins): trim private helper exports (#105687)

vincentkoc · web-flow · commit c25cd32c287a · 2026-07-12T22:26:14.000+02:00
diff --git a/extensions/browser/src/browser/system-chrome-cookies.ts b/extensions/browser/src/browser/system-chrome-cookies.ts
@@ -67,10 +67,7 @@ function isAsciiWhitespace(value: number): boolean {
 }
 
 /** Read the browser Safe Storage secret. The OS consent prompt is intentional. */
-export async function readKeychainSecret(
-  entry: KeychainEntry,
-  signal?: AbortSignal,
-): Promise<Buffer> {
+async function readKeychainSecret(entry: KeychainEntry, signal?: AbortSignal): Promise<Buffer> {
   signal?.throwIfAborted();
   return await new Promise((resolve, reject) => {
     execFile(
diff --git a/extensions/feishu/src/chat-type.ts b/extensions/feishu/src/chat-type.ts
@@ -10,7 +10,7 @@ export function normalizeFeishuChatType(value: unknown): ResolvedFeishuChatType
   return undefined;
 }
 
-export function normalizeFeishuChatMode(value: unknown): ResolvedFeishuChatType | undefined {
+function normalizeFeishuChatMode(value: unknown): ResolvedFeishuChatType | undefined {
   if (value === "group" || value === "topic" || value === "topic_group") {
     return "group";
   }
diff --git a/extensions/irc/src/policy.ts b/extensions/irc/src/policy.ts
@@ -2,7 +2,7 @@
 import { normalizeLowercaseStringOrEmpty } from "openclaw/plugin-sdk/string-coerce-runtime";
 import type { IrcChannelConfig } from "./types.js";
 
-export type IrcGroupMatch = {
+type IrcGroupMatch = {
   allowed: boolean;
   groupConfig?: IrcChannelConfig;
   wildcardConfig?: IrcChannelConfig;
diff --git a/scripts/deadcode-exports.baseline.mjs b/scripts/deadcode-exports.baseline.mjs
@@ -234,7 +234,6 @@ export const KNIP_UNUSED_EXPORT_BASELINE = [
   "extensions/browser/src/browser/system-chrome-cookies.ts: decryptChromeCookieRows",
   "extensions/browser/src/browser/system-chrome-cookies.ts: mapChromeSameSite",
   "extensions/browser/src/browser/system-chrome-cookies.ts: PlaywrightCookie",
-  "extensions/browser/src/browser/system-chrome-cookies.ts: readKeychainSecret",
   "extensions/browser/src/browser/system-profiles.ts: resolveSystemBrowserRoot",
   "extensions/browser/src/browser/system-profiles.ts: resolveSystemCookiesFile",
   "extensions/browser/src/browser/system-profiles.ts: snapshotCookieDatabase",
@@ -786,7 +785,6 @@ export const KNIP_UNUSED_EXPORT_BASELINE = [
   "extensions/feishu/src/card-action.ts: resetProcessedFeishuCardActionTokensForTests",
   "extensions/feishu/src/card-ux-launcher.ts: createQuickActionLauncherCard",
   "extensions/feishu/src/card-ux-launcher.ts: isFeishuQuickActionMenuEventKey",
-  "extensions/feishu/src/chat-type.ts: normalizeFeishuChatMode",
   "extensions/feishu/src/chat-type.ts: ResolvedFeishuChatType",
   "extensions/feishu/src/client.ts: clearClientCache",
   "extensions/feishu/src/client.ts: FEISHU_HTTP_TIMEOUT_ENV_VAR",
@@ -892,7 +890,6 @@ export const KNIP_UNUSED_EXPORT_BASELINE = [
   "extensions/irc/src/config-schema.ts: IrcConfigSchema",
   "extensions/irc/src/control-chars.ts: isIrcControlChar",
   "extensions/irc/src/monitor.ts: resolveIrcInboundTarget",
-  "extensions/irc/src/policy.ts: IrcGroupMatch",
   "extensions/irc/src/runtime.ts: clearIrcRuntime",
   "extensions/line/src/accounts.ts: DEFAULT_ACCOUNT_ID",
   "extensions/line/src/auto-reply-delivery.ts: LineAutoReplyDeps",

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ export function normalizeFeishuChatType(value: unknown): ResolvedFeishuChatType`
`10`	`10`	`return undefined;`
`11`	`11`	`}`
`12`	`12`
`13`		`-export function normalizeFeishuChatMode(value: unknown): ResolvedFeishuChatType \| undefined {`
	`13`	`+function normalizeFeishuChatMode(value: unknown): ResolvedFeishuChatType \| undefined {`
`14`	`14`	`if (value === "group" \|\| value === "topic" \|\| value === "topic_group") {`
`15`	`15`	`return "group";`
`16`	`16`	`}`