fix: reject fractional PDF page numbers

qingminlong · qingminlong · commit c18f5e2d6d8d · 2026-07-06T12:09:48.000+08:00
diff --git a/src/agents/tools/pdf-tool.helpers.test.ts b/src/agents/tools/pdf-tool.helpers.test.ts
@@ -82,6 +82,10 @@ describe("parsePageRange", () => {
     expect(() => parsePageRange("0", 20)).toThrow("Invalid page number");
   });
 
+  it("throws on fractional page number", () => {
+    expect(() => parsePageRange("1.5", 20)).toThrow('Invalid page number: "1.5"');
+  });
+
   it("throws on negative page number", () => {
     expect(() => parsePageRange("-1", 20)).toThrow("Invalid page number");
   });
diff --git a/src/agents/tools/pdf-tool.helpers.ts b/src/agents/tools/pdf-tool.helpers.ts
@@ -66,7 +66,7 @@ export function parsePageRange(range: string, maxPages: number): number[] {
       }
     } else {
       const num = Number(part);
-      if (!Number.isFinite(num) || num < 1) {
+      if (!Number.isFinite(num) || !Number.isInteger(num) || num < 1) {
         throw new Error(`Invalid page number: "${part}"`);
       }
       if (num <= maxPages) {
diff --git a/src/agents/tools/pdf-tool.test.ts b/src/agents/tools/pdf-tool.test.ts
@@ -309,6 +309,26 @@ describe("createPdfTool", () => {
     });
   });
 
+  it("rejects fractional page numbers before native PDF analysis", async () => {
+    await withTempPdfAgentDir(async (agentDir) => {
+      await stubPdfToolInfra(agentDir, { provider: "anthropic", input: ["text", "document"] });
+      const nativeSpy = vi
+        .spyOn(pdfNativeProviders, "anthropicAnalyzePdf")
+        .mockResolvedValue("native summary");
+      const cfg = withPdfModel(ANTHROPIC_PDF_MODEL);
+      const tool = requirePdfTool((await loadCreatePdfTool())({ config: cfg, agentDir }));
+
+      await expect(
+        tool.execute("t1", {
+          prompt: "summarize",
+          pdf: "/tmp/doc.pdf",
+          pages: "1.5",
+        }),
+      ).rejects.toThrow('Invalid page number: "1.5"');
+      expect(nativeSpy).not.toHaveBeenCalled();
+    });
+  });
+
   it("passes validated maxBytesMb to PDF loading", async () => {
     await withTempPdfAgentDir(async (agentDir) => {
       const { loadSpy } = await stubPdfToolInfra(agentDir, {

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ export function parsePageRange(range: string, maxPages: number): number[] {`
`66`	`66`	`}`
`67`	`67`	`} else {`
`68`	`68`	`const num = Number(part);`
`69`		`- if (!Number.isFinite(num) \|\| num < 1) {`
	`69`	`+ if (!Number.isFinite(num) \|\| !Number.isInteger(num) \|\| num < 1) {`
`70`	`70`	throw new Error(`Invalid page number: "${part}"`);
`71`	`71`	`}`
`72`	`72`	`if (num <= maxPages) {`