fix(clawhub): prevent temp workspace from chmod'ing shared /tmp to 0700

chenxiaoyu209 · claude · chenxiaoyu209 · commit c085a773a0d2 · 2026-07-07T12:39:17.000+08:00
When createTempDownloadTarget is called with tmpDir: os.tmpdir(), the @openclaw/fs-safe tempWorkspace helper calls ensurePrivateDirectory which unconditionally chmods the root directory to 0700. Passing /tmp as rootDir causes the shared system /tmp to be chmod'd, breaking all other services that depend on world-writable /tmp (MySQL, PHP-FPM, etc.). - Remove 5 explicit tmpDir: os.tmpdir() overrides from clawhub.ts download functions, letting createTempDownloadTarget use its safe default resolvePreferredOpenClawTmpDir() which resolves to the OpenClaw-owned /tmp/openclaw directory. - Change withTempDir default rootDir from os.tmpdir() to resolvePreferredOpenClawTmpDir() so all callers that don't pass an explicit rootDir are safe. - Add regression test verifying temp dirs are created under the OpenClaw-owned temp root, not directly under /tmp. Fixes #101224 Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/src/infra/clawhub.ts b/src/infra/clawhub.ts
@@ -1385,7 +1385,6 @@ export async function downloadClawHubPackageArchive(params: {
     const target = await createTempDownloadTarget({
       prefix: "openclaw-clawhub-clawpack",
       fileName: npmTarballName,
-      tmpDir: os.tmpdir(),
     });
     await fs.writeFile(target.path, bytes);
     return {
@@ -1428,7 +1427,6 @@ export async function downloadClawHubPackageArchive(params: {
   const target = await createTempDownloadTarget({
     prefix: "openclaw-clawhub-package",
     fileName: `${params.name}.zip`,
-    tmpDir: os.tmpdir(),
   });
   await fs.writeFile(target.path, bytes);
   return {
@@ -1475,7 +1473,6 @@ export async function downloadClawHubSkillArchive(params: {
   const target = await createTempDownloadTarget({
     prefix: "openclaw-clawhub-skill",
     fileName: `${params.slug}.zip`,
-    tmpDir: os.tmpdir(),
   });
   await fs.writeFile(target.path, bytes);
   return {
@@ -1518,7 +1515,6 @@ export async function downloadClawHubSkillArchiveUrl(params: {
   const target = await createTempDownloadTarget({
     prefix: "openclaw-clawhub-skill",
     fileName: "skill.zip",
-    tmpDir: os.tmpdir(),
   });
   await fs.writeFile(target.path, bytes);
   return {
@@ -1555,7 +1551,6 @@ export async function downloadClawHubGitHubSkillArchive(params: {
   const target = await createTempDownloadTarget({
     prefix: "openclaw-clawhub-github-skill",
     fileName: `${params.commit}.zip`,
-    tmpDir: os.tmpdir(),
   });
   await fs.writeFile(target.path, bytes);
   return {
diff --git a/src/infra/install-source-utils.test.ts b/src/infra/install-source-utils.test.ts
@@ -8,6 +8,7 @@ import {
   resolveArchiveSourcePath,
   withTempDir,
 } from "./install-source-utils.js";
+import { resolvePreferredOpenClawTmpDir } from "./tmp-openclaw-dir.js";
 
 const execFileSyncMock = vi.hoisted(() => vi.fn(() => "/tmp/openclaw-test-global-npmrc\n"));
 const runCommandWithTimeoutMock = vi.fn();
@@ -145,6 +146,21 @@ describe("withTempDir", () => {
     expect(value).toBe("done");
     await expectPathMissing(observedDir);
   });
+
+  it("uses OpenClaw-owned temp root instead of shared /tmp to avoid chmod of system directories", async () => {
+    const preferredRoot = resolvePreferredOpenClawTmpDir();
+    let observedDir = "";
+
+    await withTempDir("openclaw-install-source-utils-", async (tmpDir) => {
+      observedDir = tmpDir;
+      await fs.writeFile(path.join(tmpDir, "ok"), "ok", "utf-8");
+    });
+
+    // The temp dir must be under the OpenClaw-owned root, not directly under /tmp.
+    // This prevents the underlying temp workspace from chmod'ing the shared /tmp.
+    expect(observedDir.startsWith(preferredRoot)).toBe(true);
+    await expectPathMissing(observedDir);
+  });
 });
 
 describe("resolveArchiveSourcePath", () => {
diff --git a/src/infra/install-source-utils.ts b/src/infra/install-source-utils.ts
@@ -1,6 +1,5 @@
 // Resolves and packages install sources for plugin installs.
 import fs from "node:fs/promises";
-import os from "node:os";
 import path from "node:path";
 import { isRecord } from "@openclaw/normalization-core/record-coerce";
 import { normalizeOptionalString } from "@openclaw/normalization-core/string-coerce";
@@ -11,6 +10,7 @@ import { resolveArchiveKind } from "./archive.js";
 import { pathExists } from "./fs-safe.js";
 import { applyNpmFreshnessBypassEnv, type NpmProjectInstallEnvOptions } from "./npm-install-env.js";
 import { withTempWorkspace } from "./private-temp-workspace.js";
+import { resolvePreferredOpenClawTmpDir } from "./tmp-openclaw-dir.js";
 
 /** Metadata npm reports when resolving a registry spec or packed archive. */
 export type NpmSpecResolution = {
@@ -141,7 +141,7 @@ export async function withTempDir<T>(
   fn: (tmpDir: string) => Promise<T>,
   options?: { rootDir?: string },
 ): Promise<T> {
-  const rootDir = options?.rootDir ?? os.tmpdir();
+  const rootDir = options?.rootDir ?? resolvePreferredOpenClawTmpDir();
   return await withTempWorkspace({ rootDir, prefix }, async (tmp) => fn(tmp.dir));
 }
 
