fix(release): reject validation flag values

vincentkoc · vincentkoc · commit bda05dbc2f15 · 2026-06-21T20:05:22.000+02:00
diff --git a/scripts/full-release-validation-at-sha.mjs b/scripts/full-release-validation-at-sha.mjs
@@ -44,7 +44,7 @@ function runStatus(command, args, options = {}) {
 
 function readOptionValue(argv, index, optionName) {
   const value = argv[index + 1];
-  if (value === undefined || value === "" || value.startsWith("--")) {
+  if (value === undefined || value === "" || value.startsWith("-")) {
     throw new Error(`${optionName} requires a value`);
   }
   return value;
diff --git a/test/scripts/full-release-validation-at-sha.test.ts b/test/scripts/full-release-validation-at-sha.test.ts
@@ -30,7 +30,10 @@ describe("full-release-validation-at-sha", () => {
 
   it("rejects missing option values", () => {
     expect(() => parseArgs(["--sha", "--dry-run"])).toThrow("--sha requires a value");
+    expect(() => parseArgs(["--sha", "-h"])).toThrow("--sha requires a value");
     expect(() => parseArgs(["--branch"])).toThrow("--branch requires a value");
+    expect(() => parseArgs(["--branch", "-h"])).toThrow("--branch requires a value");
     expect(() => parseArgs(["-f", "--dry-run"])).toThrow("-f requires a value");
+    expect(() => parseArgs(["-f", "-h"])).toThrow("-f requires a value");
   });
 });

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ function runStatus(command, args, options = {}) {`
`44`	`44`
`45`	`45`	`function readOptionValue(argv, index, optionName) {`
`46`	`46`	`const value = argv[index + 1];`
`47`		`- if (value === undefined \|\| value === "" \|\| value.startsWith("--")) {`
	`47`	`+ if (value === undefined \|\| value === "" \|\| value.startsWith("-")) {`
`48`	`48`	throw new Error(`${optionName} requires a value`);
`49`	`49`	`}`
`50`	`50`	`return value;`