fix(clownfish): address review for symlink-test-repair-autonomous-20260621 (1)

openclaw-clownfish[bot] · openclaw-clownfish[bot] · commit bc8fcfa3c9d1 · 2026-06-21T14:03:59.000Z
diff --git a/extensions/qqbot/src/engine/utils/file-utils.test.ts b/extensions/qqbot/src/engine/utils/file-utils.test.ts
@@ -40,18 +40,15 @@ describe("qqbot file-utils MIME helpers", () => {
   });
 });
 
-async function canCreateFileSymlink(): Promise<boolean> {
-  const probeDir = await fs.promises.mkdtemp(path.join(os.tmpdir(), "qqbot-symlink-probe-"));
-  const targetPath = path.join(probeDir, "target.txt");
-  const linkPath = path.join(probeDir, "link.txt");
+async function createSymlinkedFile(targetPath: string, linkPath: string): Promise<boolean> {
   try {
-    await fs.promises.writeFile(targetPath, "probe");
+    await fs.promises.writeFile(targetPath, "image-bytes");
     await fs.promises.symlink(targetPath, linkPath, "file");
     return true;
   } catch {
+    await fs.promises.rm(linkPath, { force: true });
+    await fs.promises.rm(targetPath, { force: true });
     return false;
-  } finally {
-    await fs.promises.rm(probeDir, { recursive: true, force: true });
   }
 }
 
@@ -115,14 +112,11 @@ describe("qqbot file-utils downloadFile", () => {
   // Keep the local skipIf shape while probing inside the test, avoiding
   // import-time filesystem side effects on hosts that cannot create links.
   it.skipIf(false)("rejects symlinked local media helpers", async ({ skip }) => {
-    if (!(await canCreateFileSymlink())) {
-      skip("file symlinks are unavailable on this host");
-    }
-
     const targetPath = path.join(tempDir, "target.png");
     const linkPath = path.join(tempDir, "link.png");
-    await fs.promises.writeFile(targetPath, "image-bytes");
-    await fs.promises.symlink(targetPath, linkPath, "file");
+    if (!(await createSymlinkedFile(targetPath, linkPath))) {
+      skip("file symlinks are unavailable on this host");
+    }
 
     expect(checkFileSize(linkPath).ok).toBe(false);
     await expect(readFileAsync(linkPath)).rejects.toThrow(/symbolic link|symlink|regular file/i);
diff --git a/extensions/zalo/src/token.test.ts b/extensions/zalo/src/token.test.ts
@@ -6,18 +6,15 @@ import { describe, expect, it } from "vitest";
 import { resolveZaloToken } from "./token.js";
 import type { ZaloConfig } from "./types.js";
 
-function canCreateFileSymlink(): boolean {
-  const probeDir = fs.mkdtempSync(path.join(os.tmpdir(), "zalo-symlink-probe-"));
-  const targetPath = path.join(probeDir, "target.txt");
-  const linkPath = path.join(probeDir, "link.txt");
+function createSymlinkedFile(targetPath: string, linkPath: string): boolean {
   try {
-    fs.writeFileSync(targetPath, "probe", "utf8");
+    fs.writeFileSync(targetPath, "file-token\n", "utf8");
     fs.symlinkSync(targetPath, linkPath, "file");
     return true;
   } catch {
+    fs.rmSync(linkPath, { force: true });
+    fs.rmSync(targetPath, { force: true });
     return false;
-  } finally {
-    fs.rmSync(probeDir, { recursive: true, force: true });
   }
 }
 
@@ -95,14 +92,11 @@ describe("resolveZaloToken", () => {
   it.runIf(true)("rejects symlinked token files", ({ skip }) => {
     const dir = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-zalo-token-"));
     try {
-      if (!canCreateFileSymlink()) {
-        skip("file symlinks are unavailable on this host");
-      }
-
       const tokenFile = path.join(dir, "token.txt");
       const tokenLink = path.join(dir, "token-link.txt");
-      fs.writeFileSync(tokenFile, "file-token\n", "utf8");
-      fs.symlinkSync(tokenFile, tokenLink, "file");
+      if (!createSymlinkedFile(tokenFile, tokenLink)) {
+        skip("file symlinks are unavailable on this host");
+      }
 
       const cfg = {
         tokenFile: tokenLink,
