test: gate symlink assertions on file symlink capability

vincentkoc · aniruddhaadak80 · vincentkoc · commit bc14842ab0c8 · 2026-06-28T22:39:38.000-07:00
Co-authored-by: ANIRUDDHA ADAK &lt;127435065+aniruddhaadak80@users.noreply.github.com&gt;
diff --git a/extensions/qqbot/src/engine/utils/file-utils.test.ts b/extensions/qqbot/src/engine/utils/file-utils.test.ts
@@ -4,25 +4,18 @@ import * as os from "node:os";
 import * as path from "node:path";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 
-async function probeFileSymlinkCapability(): Promise<boolean> {
-  const probeDir = await fs.promises.mkdtemp(
-    path.join(os.tmpdir(), "openclaw-qqbot-symlink-probe-"),
-  );
-  const targetFile = path.join(probeDir, "target.txt");
-  const linkFile = path.join(probeDir, "link.txt");
+async function createSymlinkedFile(targetPath: string, linkPath: string): Promise<boolean> {
   try {
-    await fs.promises.writeFile(targetFile, "content");
-    await fs.promises.symlink(targetFile, linkFile);
+    await fs.promises.writeFile(targetPath, "image-bytes");
+    await fs.promises.symlink(targetPath, linkPath, "file");
     return true;
   } catch {
+    await fs.promises.rm(linkPath, { force: true });
+    await fs.promises.rm(targetPath, { force: true });
     return false;
-  } finally {
-    await fs.promises.rm(probeDir, { recursive: true, force: true });
   }
 }
 
-const canCreateFileSymlinks = await probeFileSymlinkCapability();
-
 const adapterMocks = vi.hoisted(() => ({
   fetchMedia: vi.fn(),
 }));
@@ -116,11 +109,12 @@ describe("qqbot file-utils downloadFile", () => {
     expect(adapterMocks.fetchMedia).not.toHaveBeenCalled();
   });
 
-  it.skipIf(!canCreateFileSymlinks)("rejects symlinked local media helpers", async () => {
+  it("rejects symlinked local media helpers", async ({ skip }) => {
     const targetPath = path.join(tempDir, "target.png");
     const linkPath = path.join(tempDir, "link.png");
-    await fs.promises.writeFile(targetPath, "image-bytes");
-    await fs.promises.symlink(targetPath, linkPath);
+    if (!(await createSymlinkedFile(targetPath, linkPath))) {
+      skip("file symlinks are unavailable on this host");
+    }
 
     expect(checkFileSize(linkPath).ok).toBe(false);
     await expect(readFileAsync(linkPath)).rejects.toThrow(/symbolic link|symlink|regular file/i);
diff --git a/extensions/zalo/src/token.test.ts b/extensions/zalo/src/token.test.ts
@@ -6,6 +6,18 @@ import { describe, expect, it } from "vitest";
 import { resolveZaloToken } from "./token.js";
 import type { ZaloConfig } from "./types.js";
 
+function createSymlinkedFile(targetPath: string, linkPath: string): boolean {
+  try {
+    fs.writeFileSync(targetPath, "file-token\n", "utf8");
+    fs.symlinkSync(targetPath, linkPath, "file");
+    return true;
+  } catch {
+    fs.rmSync(linkPath, { force: true });
+    fs.rmSync(targetPath, { force: true });
+    return false;
+  }
+}
+
 describe("resolveZaloToken", () => {
   it("falls back to top-level token for non-default accounts without overrides", () => {
     const cfg = {
@@ -75,17 +87,21 @@ describe("resolveZaloToken", () => {
     expect(res.source).toBe("config");
   });
 
-  it.runIf(process.platform !== "win32")("rejects symlinked token files", () => {
+  it("rejects symlinked token files", ({ skip }) => {
     const dir = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-zalo-token-"));
-    const tokenFile = path.join(dir, "token.txt");
-    const tokenLink = path.join(dir, "token-link.txt");
-    fs.writeFileSync(tokenFile, "file-token\n", "utf8");
-    fs.symlinkSync(tokenFile, tokenLink);
+    try {
+      const tokenFile = path.join(dir, "token.txt");
+      const tokenLink = path.join(dir, "token-link.txt");
+      if (!createSymlinkedFile(tokenFile, tokenLink)) {
+        skip("file symlinks are unavailable on this host");
+      }
 
-    const cfg = {
-      tokenFile: tokenLink,
-    } as ZaloConfig;
-    expect(() => resolveZaloToken(cfg)).toThrow(/Zalo token file.*must not be a symlink/);
-    fs.rmSync(dir, { recursive: true, force: true });
+      const cfg = {
+        tokenFile: tokenLink,
+      } as ZaloConfig;
+      expect(() => resolveZaloToken(cfg)).toThrow(/Zalo token file.*must not be a symlink/);
+    } finally {
+      fs.rmSync(dir, { recursive: true, force: true });
+    }
   });
 });
