fix: filter out error payloads from user-facing messages

Suksham-sharma · Suksham-sharma · commit b981813901d0 · 2026-02-16T15:34:56.000+05:30
isRenderablePayload did not check the isError flag, causing internal error results (context overflow, tool failures, role ordering conflicts) to leak to users on all messaging channels. These errors are meant to stay in the agent context for self-correction, not be delivered. Add tests for isRenderablePayload covering all payload types and the isError filtering behavior. Fixes #17828
diff --git a/src/auto-reply/reply/reply-payloads.test.ts b/src/auto-reply/reply/reply-payloads.test.ts
@@ -0,0 +1,42 @@
+import { describe, expect, it } from "vitest";
+import { isRenderablePayload } from "./reply-payloads.js";
+
+describe("isRenderablePayload", () => {
+  it("returns true for payload with text", () => {
+    expect(isRenderablePayload({ text: "hello" })).toBe(true);
+  });
+
+  it("returns true for payload with mediaUrl", () => {
+    expect(isRenderablePayload({ mediaUrl: "https://example.com/img.png" })).toBe(true);
+  });
+
+  it("returns true for payload with mediaUrls", () => {
+    expect(isRenderablePayload({ mediaUrls: ["https://example.com/a.png"] })).toBe(true);
+  });
+
+  it("returns true for payload with audioAsVoice", () => {
+    expect(isRenderablePayload({ audioAsVoice: true })).toBe(true);
+  });
+
+  it("returns true for payload with channelData", () => {
+    expect(isRenderablePayload({ channelData: { key: "value" } })).toBe(true);
+  });
+
+  it("returns false for empty payload", () => {
+    expect(isRenderablePayload({})).toBe(false);
+  });
+
+  it("returns false for error payload even with text", () => {
+    expect(isRenderablePayload({ text: "Context overflow error", isError: true })).toBe(false);
+  });
+
+  it("returns false for error payload with media", () => {
+    expect(isRenderablePayload({ mediaUrl: "https://example.com/img.png", isError: true })).toBe(
+      false,
+    );
+  });
+
+  it("returns true for non-error payload with isError explicitly false", () => {
+    expect(isRenderablePayload({ text: "hello", isError: false })).toBe(true);
+  });
+});
diff --git a/src/auto-reply/reply/reply-payloads.ts b/src/auto-reply/reply/reply-payloads.ts
@@ -45,6 +45,9 @@ export function applyReplyTagsToPayload(
 }
 
 export function isRenderablePayload(payload: ReplyPayload): boolean {
+  if (payload.isError) {
+    return false;
+  }
   return Boolean(
     payload.text ||
     payload.mediaUrl ||

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,9 @@ export function applyReplyTagsToPayload(`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`export function isRenderablePayload(payload: ReplyPayload): boolean {`
	`48`	`+ if (payload.isError) {`
	`49`	`+ return false;`
	`50`	`+ }`
`48`	`51`	`return Boolean(`
`49`	`52`	`payload.text \|\|`
`50`	`53`	`payload.mediaUrl \|\|`