fix(reply): keep inherited routes unthreaded

MonkeyLeeT · MonkeyLeeT · commit b8fb236c56c8 · 2026-05-31T20:19:07.000-07:00
diff --git a/src/auto-reply/reply/dispatch-from-config.test.ts b/src/auto-reply/reply/dispatch-from-config.test.ts
@@ -1420,6 +1420,48 @@ describe("dispatchReplyFromConfig", () => {
     expect(replyDispatchCall?.[0]?.originatingTo).toBe("user:ou_123");
   });
 
+  it("does not borrow the live webchat thread for unthreaded inherited sessions_send routes", async () => {
+    setNoAbort();
+    mocks.routeReply.mockClear();
+    sessionStoreMocks.currentEntry = {
+      deliveryContext: {
+        channel: "feishu",
+        to: "user:ou_123",
+        accountId: "work",
+      },
+      lastChannel: "feishu",
+      lastTo: "user:ou_123",
+      lastAccountId: "work",
+    };
+    const cfg = emptyConfig;
+    const dispatcher = createDispatcher();
+    const ctx = buildTestCtx({
+      Provider: "webchat",
+      Surface: "webchat",
+      SessionKey: "agent:main:feishu:direct:ou_123",
+      AccountId: undefined,
+      MessageThreadId: "internal-webchat-thread",
+      OriginatingChannel: "webchat",
+      OriginatingTo: "session:dashboard",
+      InputProvenance: {
+        kind: "inter_session",
+        sourceTool: "sessions_send",
+        sourceChannel: "webchat",
+      },
+    });
+
+    const replyResolver = async () => ({ text: "hi" }) satisfies ReplyPayload;
+    await dispatchReplyFromConfig({ ctx, cfg, dispatcher, replyResolver });
+
+    expect(dispatcher.sendFinalReply).not.toHaveBeenCalled();
+    const routeCall = firstRouteReplyCall() as
+      | { channel?: string; threadId?: string | number; to?: string }
+      | undefined;
+    expect(routeCall?.channel).toBe("feishu");
+    expect(routeCall?.to).toBe("user:ou_123");
+    expect(routeCall?.threadId).toBeUndefined();
+  });
+
   it("routes exec-event replies using last route fields when delivery context is missing", async () => {
     setNoAbort();
     mocks.routeReply.mockClear();
diff --git a/src/auto-reply/reply/dispatch-from-config.ts b/src/auto-reply/reply/dispatch-from-config.ts
@@ -1202,12 +1202,10 @@ export async function dispatchReplyFromConfig(
     ctx,
     sessionKey: acpDispatchSessionKey,
   });
-  // sessions_send inherited routes carry the persisted delivery thread; ordinary turns keep
-  // using active-turn context so normalized stale origin threads stay suppressed.
+  // sessions_send inherited routes use only the persisted delivery thread; ordinary turns
+  // keep using active-turn context so normalized stale origin threads stay suppressed.
   const routeReplyThreadId =
-    replyRoute.inheritedExternalRoute === true
-      ? (replyRoute.threadId ?? routeThreadId)
-      : routeThreadId;
+    replyRoute.inheritedExternalRoute === true ? replyRoute.threadId : routeThreadId;
   const inboundAudio = isInboundAudioContext(ctx);
   const sessionTtsAuto = normalizeTtsAutoMode(sessionStoreEntry.entry?.ttsAuto);
   const workspaceDir = resolveAgentWorkspaceDir(cfg, sessionAgentId);
