fix(plugins): stage git plugin clone on target filesystem to avoid EXDEV

Bartok9 · Bartok9 · commit b8e86a180bd1 · 2026-07-04T04:41:39.000-04:00
Git plugin installs cloned into os.tmpdir() then atomically renamed the staged repo into ~/.openclaw/git/. When /tmp and the state dir live on different filesystems (common in Docker with bind-mounted volumes), the rename failed with EXDEV: cross-device link not permitted. Stage the clone under the managed git root (same filesystem as the destination) so the final rename never crosses devices. Falls back to os.tmpdir() when the managed root cannot be prepared, preserving prior behavior. Closes #99885
diff --git a/src/infra/install-source-utils.ts b/src/infra/install-source-utils.ts
@@ -135,12 +135,23 @@ export type NpmIntegrityDrift = {
   actualIntegrity: string;
 };
 
-/** Runs a callback in a private temp directory and removes it afterward. */
+/**
+ * Runs a callback in a private temp directory and removes it afterward.
+ *
+ * By default the temp directory is created under `os.tmpdir()`. Callers that
+ * later move the staged result into a persistent location with an atomic
+ * `rename()` should pass `rootDir` pointing at (a directory on) the same
+ * filesystem as that destination. Otherwise the rename can fail with `EXDEV`
+ * ("cross-device link not permitted") when `/tmp` and the destination live on
+ * different mounts — common in containers with bind-mounted state dirs.
+ */
 export async function withTempDir<T>(
   prefix: string,
   fn: (tmpDir: string) => Promise<T>,
+  options?: { rootDir?: string },
 ): Promise<T> {
-  return await withTempWorkspace({ rootDir: os.tmpdir(), prefix }, async (tmp) => fn(tmp.dir));
+  const rootDir = options?.rootDir ?? os.tmpdir();
+  return await withTempWorkspace({ rootDir, prefix }, async (tmp) => fn(tmp.dir));
 }
 
 /** Resolves and validates a user-supplied archive path before extraction. */
diff --git a/src/plugins/git-install.test.ts b/src/plugins/git-install.test.ts
@@ -486,6 +486,47 @@ describe("installPluginFromGitSpec", () => {
     }
   });
 
+  it("stages the clone under the managed git dir so replacement never crosses filesystems (#99885)", async () => {
+    const gitDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-git-install-stage-"));
+    try {
+      runCommandWithTimeoutMock
+        .mockResolvedValueOnce({ code: 0, stdout: "", stderr: "" })
+        .mockResolvedValueOnce({ code: 0, stdout: "abc123\n", stderr: "" })
+        .mockResolvedValueOnce({ code: 0, stdout: "", stderr: "" });
+      installPluginFromInstalledPackageDirMock.mockImplementation(
+        async (params: { packageDir: string }) => {
+          await fs.mkdir(params.packageDir, { recursive: true });
+          return {
+            ok: true,
+            pluginId: "demo",
+            targetDir: params.packageDir,
+            version: "1.2.3",
+            extensions: ["index.js"],
+          };
+        },
+      );
+
+      const result = await installPluginFromGitSpec({
+        spec: "git:github.com/acme/demo",
+        gitDir,
+      });
+      expect(result.ok).toBe(true);
+      if (!result.ok) {
+        throw new Error(result.error);
+      }
+
+      // The clone destination must live under the resolved managed git dir, not
+      // os.tmpdir(). Staging elsewhere makes the final atomic rename into the
+      // persistent repo cross filesystems and fail with EXDEV in containers.
+      const cloneArgv = commandArgvAt(0);
+      const cloneDest = cloneArgv[cloneArgv.length - 1];
+      const resolvedGitDir = path.resolve(gitDir);
+      expect(path.resolve(cloneDest).startsWith(resolvedGitDir)).toBe(true);
+    } finally {
+      await fs.rm(gitDir, { recursive: true, force: true });
+    }
+  });
+
   it("uses a credential-free managed repo path for authenticated git URLs", async () => {
     const gitDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-git-install-path-"));
     try {
diff --git a/src/plugins/git-install.ts b/src/plugins/git-install.ts
