test: avoid cold startup migration timeout

steipete · steipete · commit b8dc30a72a2e · 2026-07-17T06:58:15.000-07:00
diff --git a/src/infra/state-migrations.restart-sentinel.test.ts b/src/infra/state-migrations.restart-sentinel.test.ts
@@ -21,10 +21,6 @@ import {
   writeRestartSentinel,
   type RestartSentinelPayload,
 } from "./restart-sentinel.js";
-import {
-  autoMigrateLegacyState,
-  resetAutoMigrateLegacyStateForTest,
-} from "./state-migrations.doctor.js";
 import {
   detectLegacyRestartSentinel,
   migrateLegacyRestartSentinel,
@@ -38,7 +34,6 @@ type MigrationDatabase = Pick<
 describe("legacy restart sentinel migration", () => {
   const tempDirs = useAutoCleanupTempDirTracker((cleanup) => {
     afterEach(() => {
-      resetAutoMigrateLegacyStateForTest();
       closeOpenClawStateDatabaseForTest();
       cleanup();
     });
@@ -176,21 +171,6 @@ describe("legacy restart sentinel migration", () => {
     });
   });
 
-  it("runs the same migration owner during automatic startup preflight", async () => {
-    const { env, stateDir } = useStateDir();
-    const expected = payload(321);
-    const sourcePath = await writeLegacy(stateDir, { version: 1, payload: expected });
-
-    const result = await autoMigrateLegacyState({ cfg: {}, env });
-
-    expect(result.warnings).toEqual([]);
-    expect(result.changes).toContain(
-      "Imported the legacy restart sentinel into shared SQLite state.",
-    );
-    await expect(readRestartSentinel(env)).resolves.toMatchObject({ payload: expected });
-    expect(fs.existsSync(sourcePath)).toBe(false);
-  });
-
   it("preserves a valid canonical row when legacy JSON conflicts", async () => {
     const { env, stateDir } = useStateDir();
     const canonical = payload(999);
diff --git a/src/infra/state-migrations.test.ts b/src/infra/state-migrations.test.ts
@@ -28,6 +28,7 @@ import {
   listWebPushSubscriptions,
   readPersistedVapidKeyPair,
 } from "./push-web-store.js";
+import { readRestartSentinel } from "./restart-sentinel.js";
 import {
   autoMigrateLegacyState,
   autoMigrateLegacyPluginDoctorState,
@@ -1729,7 +1730,7 @@ describe("state migrations", () => {
     await expect(fs.readFile(`${routingPath}.migrated`, "utf8")).resolves.toContain("robot wake");
   });
 
-  it("auto-migrates standalone legacy voice wake JSON settings", async () => {
+  it("auto-migrates standalone legacy JSON settings", async () => {
     const root = await createTempDir();
     const stateDir = path.join(root, ".openclaw");
     const env = createEnv(stateDir);
@@ -1741,14 +1742,31 @@ describe("state migrations", () => {
       JSON.stringify({ triggers: ["wake"] }),
       "utf8",
     );
+    const expectedSentinel = {
+      kind: "update" as const,
+      status: "ok" as const,
+      ts: 321,
+      message: "Update completed",
+    };
+    const restartSentinelPath = path.join(stateDir, "restart-sentinel.json");
+    await fs.writeFile(
+      restartSentinelPath,
+      `${JSON.stringify({ version: 1, payload: expectedSentinel })}\n`,
+      "utf8",
+    );
 
     const result = await autoMigrateLegacyState({ cfg, env, homedir: () => root });
 
     expect(result.skipped).toBe(false);
     expect(result.migrated).toBe(true);
     expect(result.warnings).toStrictEqual([]);
+    expect(result.changes).toContain(
+      "Imported the legacy restart sentinel into shared SQLite state.",
+    );
     await expect(loadVoiceWakeConfig(stateDir)).resolves.toMatchObject({ triggers: ["wake"] });
+    await expect(readRestartSentinel(env)).resolves.toMatchObject({ payload: expectedSentinel });
     await expectMissingPath(path.join(settingsDir, "voicewake.json"));
+    await expectMissingPath(restartSentinelPath);
   });
 
   it("runs plugin doctor migrations after repairing shared state schema", async () => {
