fix: validate voice-call legacy streaming numbers

steipete · steipete · commit b5d90ae4ec39 · 2026-05-28T16:43:31.000-04:00
diff --git a/extensions/voice-call/src/config-compat.test.ts b/extensions/voice-call/src/config-compat.test.ts
@@ -62,6 +62,38 @@ describe("voice-call config compatibility", () => {
     expect(streaming?.sttModel).toBeUndefined();
   });
 
+  it("does not migrate non-finite legacy streaming numbers", () => {
+    const migration = migrateVoiceCallLegacyConfigInput({
+      value: {
+        streaming: {
+          silenceDurationMs: Number.NaN,
+          vadThreshold: Number.POSITIVE_INFINITY,
+        },
+      },
+      configPathPrefix: "plugins.entries.voice-call.config",
+    });
+    const streaming = migration.config.streaming as
+      | {
+          providers?: {
+            openai?: {
+              silenceDurationMs?: number;
+              vadThreshold?: number;
+            };
+          };
+        }
+      | undefined;
+
+    expect(streaming?.providers?.openai).toBeUndefined();
+    expect(migration.changes).toEqual([
+      "Removed invalid plugins.entries.voice-call.config.streaming.silenceDurationMs.",
+      "Removed invalid plugins.entries.voice-call.config.streaming.vadThreshold.",
+    ]);
+    expect(migration.issues.map((issue) => issue.path)).toEqual([
+      "streaming.silenceDurationMs",
+      "streaming.vadThreshold",
+    ]);
+  });
+
   it("reports doctor-oriented legacy issues and warnings", () => {
     const raw = {
       provider: "log",
diff --git a/extensions/voice-call/src/config-compat.ts b/extensions/voice-call/src/config-compat.ts
@@ -15,7 +15,7 @@ const getString = readStringField;
 
 function getNumber(obj: Record<string, unknown> | undefined, key: string): number | undefined {
   const value = obj?.[key];
-  return typeof value === "number" ? value : undefined;
+  return typeof value === "number" && Number.isFinite(value) ? value : undefined;
 }
 
 function mergeProviderConfig(
@@ -204,15 +204,19 @@ export function migrateVoiceCallLegacyConfigInput(params: {
       `Moved ${configPathPrefix}.streaming.sttModel → ${configPathPrefix}.streaming.providers.openai.model.`,
     );
   }
-  if (typeof streaming?.silenceDurationMs === "number") {
+  if (getNumber(streaming, "silenceDurationMs") !== undefined) {
     changes.push(
       `Moved ${configPathPrefix}.streaming.silenceDurationMs → ${configPathPrefix}.streaming.providers.openai.silenceDurationMs.`,
     );
+  } else if (typeof streaming?.silenceDurationMs === "number") {
+    changes.push(`Removed invalid ${configPathPrefix}.streaming.silenceDurationMs.`);
   }
-  if (typeof streaming?.vadThreshold === "number") {
+  if (getNumber(streaming, "vadThreshold") !== undefined) {
     changes.push(
       `Moved ${configPathPrefix}.streaming.vadThreshold → ${configPathPrefix}.streaming.providers.openai.vadThreshold.`,
     );
+  } else if (typeof streaming?.vadThreshold === "number") {
+    changes.push(`Removed invalid ${configPathPrefix}.streaming.vadThreshold.`);
   }
 
   return { config, changes, issues };
