test: pin skill update config writes

shakkernerd · shakkernerd · commit b41d766394e0 · 2026-05-11T13:37:28.000+01:00
diff --git a/src/gateway/server-methods/skills.update.normalizes-api-key.test.ts b/src/gateway/server-methods/skills.update.normalizes-api-key.test.ts
@@ -23,6 +23,18 @@ vi.mock("../../config/config.js", () => {
 
 const { skillsHandlers } = await import("./skills.js");
 
+function expectWrittenSkillEntry(skillKey: string, entry: unknown) {
+  expect(writtenConfig).toBeDefined();
+  const config = writtenConfig as {
+    skills?: {
+      entries?: Record<string, unknown>;
+    };
+  };
+  expect(Object.keys(config).sort()).toEqual(["skills"]);
+  expect(Object.keys(config.skills ?? {}).sort()).toEqual(["entries"]);
+  expect(config.skills?.entries?.[skillKey]).toEqual(entry);
+}
+
 describe("skills.update", () => {
   it("strips embedded CR/LF from apiKey", async () => {
     writtenConfig = null;
@@ -51,14 +63,8 @@ describe("skills.update", () => {
 
     expect(ok).toBe(true);
     expect(error).toBeUndefined();
-    expect(writtenConfig).toMatchObject({
-      skills: {
-        entries: {
-          "brave-search": {
-            apiKey: "abcdef",
-          },
-        },
-      },
+    expectWrittenSkillEntry("brave-search", {
+      apiKey: "abcdef",
     });
   });
 
@@ -90,17 +96,11 @@ describe("skills.update", () => {
     });
 
     // Full values must be persisted to config
-    expect(writtenConfig).toMatchObject({
-      skills: {
-        entries: {
-          "demo-skill": {
-            apiKey: "secret-api-key-123",
-            env: {
-              GEMINI_API_KEY: "secret-env-key-456",
-              BRAVE_REGION: "us",
-            },
-          },
-        },
+    expectWrittenSkillEntry("demo-skill", {
+      apiKey: "secret-api-key-123",
+      env: {
+        GEMINI_API_KEY: "secret-env-key-456",
+        BRAVE_REGION: "us",
       },
     });
 
@@ -145,17 +145,11 @@ describe("skills.update", () => {
       respond: () => {},
     });
 
-    expect(writtenConfig).toMatchObject({
-      skills: {
-        entries: {
-          "demo-skill": {
-            apiKey: "secret-api-key-123",
-            env: {
-              GEMINI_API_KEY: "secret-env-key-456",
-              BRAVE_REGION: "eu",
-            },
-          },
-        },
+    expectWrittenSkillEntry("demo-skill", {
+      apiKey: "secret-api-key-123",
+      env: {
+        GEMINI_API_KEY: "secret-env-key-456",
+        BRAVE_REGION: "eu",
       },
     });
   });
