fix(cli): bound docs search API response reads with committed test

cxbAsDev · vincentkoc · commit b3eb3509abd7 · 2026-06-30T09:46:15.000-07:00
diff --git a/src/commands/docs.test.ts b/src/commands/docs.test.ts
@@ -94,4 +94,33 @@ describe("docsSearchCommand", () => {
     expect(runtime.exit).not.toHaveBeenCalled();
     expect(runtime.log).toHaveBeenCalled();
   });
+
+  it("rejects oversized docs search responses", async () => {
+    const ONE_MIB = 1024 * 1024;
+    const cancel = vi.fn();
+    const stream = new ReadableStream<Uint8Array>({
+      cancel,
+      start(controller) {
+        for (let i = 0; i < 10; i++) {
+          controller.enqueue(new Uint8Array(ONE_MIB));
+        }
+        controller.close();
+      },
+    });
+    fetchMock.mockResolvedValueOnce(
+      new Response(stream, {
+        status: 200,
+        headers: { "Content-Type": "application/json" },
+      }),
+    );
+    const runtime = makeRuntime();
+
+    await docsSearchCommand(["oversized"], runtime);
+
+    expect(runtime.error).toHaveBeenCalledWith(
+      expect.stringContaining("Docs search response exceeds"),
+    );
+    expect(runtime.exit).toHaveBeenCalledWith(1);
+    expect(cancel).toHaveBeenCalledOnce();
+  });
 });
diff --git a/src/commands/docs.ts b/src/commands/docs.ts
@@ -1,11 +1,13 @@
 // Implements docs link/search output for `openclaw docs`.
+import { readResponseWithLimit } from "@openclaw/media-core/read-response-with-limit";
 import { formatDocsLink } from "../../packages/terminal-core/src/links.js";
 import { isRich, theme } from "../../packages/terminal-core/src/theme.js";
 import { formatCliCommand } from "../cli/command-format.js";
 import type { RuntimeEnv } from "../runtime.js";
 
 const SEARCH_API = "https://docs.openclaw.ai/api/search";
 const SEARCH_TIMEOUT_MS = 30_000;
+const DOCS_SEARCH_RESPONSE_MAX_BYTES = 8 * 1024 * 1024;
 
 type DocResult = {
   title: string;
@@ -75,7 +77,10 @@ async function fetchDocsSearch(query: string): Promise<DocResult[]> {
     if (!response.ok) {
       throw new Error(`HTTP ${response.status}`);
     }
-    const payload = (await response.json()) as DocsSearchResponse;
+    const bytes = await readResponseWithLimit(response, DOCS_SEARCH_RESPONSE_MAX_BYTES, {
+      onOverflow: ({ maxBytes }) => new Error(`Docs search response exceeds ${maxBytes} bytes`),
+    });
+    const payload = JSON.parse(new TextDecoder().decode(bytes)) as DocsSearchResponse;
     return parseDocsSearchResults(payload.results);
   } finally {
     clearTimeout(timeout);
