fix(doctor): keep dry-run preflight read-only

giodl73-repo · giodl73-repo · commit b3563d3f3404 · 2026-06-22T09:53:13.000-07:00
diff --git a/src/commands/doctor-config-flow.test.ts b/src/commands/doctor-config-flow.test.ts
@@ -8,6 +8,7 @@ import {
   getDoctorConfigInputForTest,
   runDoctorConfigWithInput,
 } from "./doctor-config-flow.test-utils.js";
+import { runDoctorConfigPreflight } from "./doctor-config-preflight.js";
 
 type TerminalNote = (message: string, title?: string) => void;
 
@@ -1509,6 +1510,7 @@ describe("doctor config flow", () => {
     callGatewayMock.mockReset();
     callGatewayMock.mockResolvedValue({});
     runDoctorRepairSequenceMock.mockReset();
+    vi.mocked(runDoctorConfigPreflight).mockClear();
     collectDoctorPreviewNotesParamsMock.mockClear();
     collectImplicitFallbackClobberWarningsMock.mockClear();
     collectImplicitFallbackClobberWarningsMock.mockReturnValue([]);
@@ -1529,6 +1531,63 @@ describe("doctor config flow", () => {
     });
   });
 
+  it("does not run state or legacy config migrations for dry-run previews", async () => {
+    await runDoctorConfigWithInput({
+      config: {},
+      run: ({ confirm }) =>
+        loadAndMaybeMigrateDoctorConfig({
+          options: { nonInteractive: true, dryRun: true },
+          confirm: async () => confirm(),
+        }),
+    });
+
+    expect(runDoctorConfigPreflight).toHaveBeenCalledWith(
+      expect.objectContaining({
+        migrateState: false,
+        migrateLegacyConfig: false,
+        repairPrefixedConfig: false,
+        recoverCorruptTargetStore: false,
+      }),
+    );
+  });
+
+  it("does not run state or legacy config migrations for diff previews", async () => {
+    await runDoctorConfigWithInput({
+      config: {},
+      run: ({ confirm }) =>
+        loadAndMaybeMigrateDoctorConfig({
+          options: { nonInteractive: true, diff: true },
+          confirm: async () => confirm(),
+        }),
+    });
+
+    expect(runDoctorConfigPreflight).toHaveBeenCalledWith(
+      expect.objectContaining({
+        migrateState: false,
+        migrateLegacyConfig: false,
+        repairPrefixedConfig: false,
+        recoverCorruptTargetStore: false,
+      }),
+    );
+  });
+
+  it("keeps migrations enabled for repair runs", async () => {
+    await runDoctorConfigWithInput({
+      config: {},
+      repair: true,
+      run: loadAndMaybeMigrateDoctorConfig,
+    });
+
+    expect(runDoctorConfigPreflight).toHaveBeenCalledWith(
+      expect.objectContaining({
+        migrateState: true,
+        migrateLegacyConfig: true,
+        repairPrefixedConfig: true,
+        recoverCorruptTargetStore: true,
+      }),
+    );
+  });
+
   it("collects plugin blocker previews from the pre-auto-enable config", async () => {
     await runDoctorConfigWithInput({
       config: {
diff --git a/src/commands/doctor-config-flow.ts b/src/commands/doctor-config-flow.ts
@@ -11,7 +11,6 @@ import {
   noteOpencodeProviderOverrides,
 } from "./doctor-config-analysis.js";
 import { runDoctorConfigPreflight } from "./doctor-config-preflight.js";
-import { normalizeCompatibilityConfigValues } from "./doctor/shared/legacy-config-core-migrate.js";
 import type { DoctorOptions, DoctorPrompter } from "./doctor-prompter.js";
 import { emitDoctorNotes, sanitizeDoctorNote } from "./doctor/emit-notes.js";
 import { finalizeDoctorConfigFlow } from "./doctor/finalize-config-flow.js";
@@ -24,6 +23,7 @@ import {
   collectMissingDefaultAccountBindingWarnings,
   collectMissingExplicitDefaultAccountWarnings,
 } from "./doctor/shared/default-account-warnings.js";
+import { normalizeCompatibilityConfigValues } from "./doctor/shared/legacy-config-core-migrate.js";
 
 function hasLegacyInternalHookHandlers(raw: unknown): boolean {
   const handlers = (raw as { hooks?: { internal?: { handlers?: unknown } } })?.hooks?.internal
@@ -142,7 +142,10 @@ export async function loadAndMaybeMigrateDoctorConfig(params: {
   prompter?: DoctorPrompter;
 }) {
   const shouldRepair = params.options.repair === true || params.options.yes === true;
+  const previewOnly = params.options.dryRun === true || params.options.diff === true;
   const preflight = await runDoctorConfigPreflight({
+    migrateState: !previewOnly,
+    migrateLegacyConfig: !previewOnly,
     repairPrefixedConfig: shouldRepair,
     recoverCorruptTargetStore: shouldRepair,
   });
