Merge 4682290 into d4a01e4

ly-wang19 · web-flow · commit b2c869bdd99a · 2026-06-26T21:44:50.000Z
diff --git a/packages/memory-host-sdk/src/host/embeddings.test.ts b/packages/memory-host-sdk/src/host/embeddings.test.ts
@@ -36,7 +36,9 @@ function createDeferred<T>() {
   return { promise, resolve, reject };
 }
 
-function mockLocalEmbeddingRuntime(vector = new Float32Array([2.35, 3.45, 0.63, 4.3])) {
+function mockLocalEmbeddingRuntime(
+  vector: ArrayLike<number> = new Float32Array([2.35, 3.45, 0.63, 4.3]),
+) {
   const disposeContext = vi.fn();
   const disposeModel = vi.fn();
   const disposeLlama = vi.fn();
@@ -111,6 +113,26 @@ describe("local embedding provider", () => {
     await expect(provider.embedBatch(["test document"])).resolves.toEqual([[0.6, 0.8]]);
   });
 
+  it("does not read local embedding coordinates past outputDimensionality", async () => {
+    mockLocalEmbeddingRuntime({
+      length: 3,
+      0: 3,
+      1: 4,
+      get 2(): number {
+        throw new Error("tail coordinate should not be read");
+      },
+    });
+    const provider = await createLocalEmbeddingProviderInProcess({
+      config: {} as never,
+      provider: "local",
+      model: "",
+      fallback: "none",
+      outputDimensionality: 2,
+    });
+
+    await expect(provider.embedQuery("test query")).resolves.toEqual([0.6, 0.8]);
+  });
+
   it("passes default contextSize (4096) to createEmbeddingContext when not configured", async () => {
     const runtime = mockLocalEmbeddingRuntime();
 
diff --git a/packages/memory-host-sdk/src/host/embeddings.ts b/packages/memory-host-sdk/src/host/embeddings.ts
@@ -31,6 +31,15 @@ export type LocalEmbeddingProviderRuntimeOptions = {
   nodeLlamaCppImportUrl?: string;
 };
 
+function copyEmbeddingVector(vector: ArrayLike<number>, maxLength?: number): number[] {
+  const length = Math.min(maxLength ?? vector.length, vector.length);
+  const values: number[] = [];
+  for (let index = 0; index < length; index += 1) {
+    values.push(vector[index]);
+  }
+  return values;
+}
+
 async function disposeResources(
   resources: Array<DisposableResource | null | undefined>,
 ): Promise<void> {
@@ -144,9 +153,7 @@ export async function createLocalEmbeddingProviderInProcess(
   const outputDimensionality =
     typeof options.outputDimensionality === "number" ? options.outputDimensionality : undefined;
   const normalize = (vector: ArrayLike<number>): number[] =>
-    sanitizeAndNormalizeEmbedding(
-      outputDimensionality ? Array.from(vector).slice(0, outputDimensionality) : Array.from(vector),
-    );
+    sanitizeAndNormalizeEmbedding(copyEmbeddingVector(vector, outputDimensionality));
 
   return {
     id: "local",
