fix(memory-core): strip dreaming blocks from partial reads of daily files

jasonmakr · jasonmakr · commit b20b72e61d67 · 2026-04-18T06:26:09.000Z
Previously, memory_get calls with from/lines parameters on daily memory files (memory/YYYY-MM-DD.md) bypassed the dreaming block filter, leaking cross-session staging data from Light Sleep and REM Sleep phases. The fix redirects partial reads of daily files through the full-read path: read the entire file, strip dreaming managed blocks, then slice the requested line range from the cleaned content. This ensures line numbers are consistent with a full read and no staging data is ever exposed. Non-daily files continue to use the efficient streaming partial read path, since they never contain dreaming blocks. Daily memory files are small (a few KB) so the overhead of a full read is negligible. Resolves the TODO(#68367) left in the initial implementation. Addresses review feedback on #68408.
diff --git a/extensions/memory-core/src/memory/qmd-manager.test.ts b/extensions/memory-core/src/memory/qmd-manager.test.ts
@@ -3604,6 +3604,59 @@ describe("QmdMemoryManager", () => {
     readFileSpy.mockRestore();
   });
 
+  it("strips dreaming managed blocks from partial reads of daily memory files", async () => {
+    const relPath = path.join("memory", "2026-04-18.md");
+    await fs.mkdir(path.join(workspaceDir, "memory"), { recursive: true });
+    const lines = [
+      "# 2026-04-18 Daily Log",
+      "",
+      "## Morning notes",
+      "line-4",
+      "line-5",
+      "## Light Sleep",
+      "<!-- openclaw:dreaming:light:start -->",
+      "dreaming-candidate-1",
+      "dreaming-candidate-2",
+      "<!-- openclaw:dreaming:light:end -->",
+      "",
+      "## Afternoon notes",
+      "line-13",
+      "line-14",
+    ];
+    await fs.writeFile(path.join(workspaceDir, relPath), lines.join("\n"), "utf-8");
+
+    const { manager } = await createManager();
+
+    // Partial read that would span the dreaming block in the raw file
+    const result = await manager.readFile({ relPath, from: 1, lines: 10 });
+    expect(result.text).not.toContain("dreaming-candidate");
+    expect(result.text).not.toContain("openclaw:dreaming");
+    expect(result.text).toContain("Morning notes");
+    expect(result.text).toContain("Afternoon notes");
+
+    await manager.close();
+  });
+
+  it("uses efficient streaming partial read for non-daily memory files", async () => {
+    const readFileSpy = vi.spyOn(fs, "readFile");
+    const relPath = path.join("memory", "window.md");
+    await fs.mkdir(path.join(workspaceDir, "memory"), { recursive: true });
+    await fs.writeFile(
+      path.join(workspaceDir, relPath),
+      Array.from({ length: 20 }, (_, i) => `line-${i + 1}`).join("\n"),
+      "utf-8",
+    );
+
+    const { manager } = await createManager();
+    const result = await manager.readFile({ relPath, from: 5, lines: 3 });
+    expect(result.text).toContain("line-5");
+    // Non-daily files should use streaming partial read, not readFile
+    expect(readFileSpy).not.toHaveBeenCalled();
+
+    await manager.close();
+    readFileSpy.mockRestore();
+  });
+
   it("returns a bounded default excerpt for qmd memory reads without explicit lines", async () => {
     const relPath = path.join("memory", "default-window.md");
     await fs.mkdir(path.join(workspaceDir, "memory"), { recursive: true });
diff --git a/extensions/memory-core/src/memory/qmd-manager.ts b/extensions/memory-core/src/memory/qmd-manager.ts
@@ -1208,6 +1208,28 @@ export class QmdMemoryManager implements MemorySearchManager {
     }
     const contextLimits = resolveAgentContextLimits(this.cfg, this.agentId);
     if (params.from !== undefined || params.lines !== undefined) {
+      // For daily memory files, read the full file and strip dreaming blocks
+      // before slicing so that line numbers are consistent with a full read
+      // and cross-session staging data is never exposed.  Daily files are
+      // small (a few KB) so the overhead of a full read is negligible.
+      // See openclaw/openclaw#68367.
+      if (isDailyMemoryPath(relPath)) {
+        const full = await this.readFullText(absPath);
+        if (full.missing) {
+          return { text: "", path: relPath };
+        }
+        const stripped = stripDreamingManagedBlocks(full.text);
+        return buildMemoryReadResult({
+          content: stripped,
+          relPath,
+          from: params.from,
+          lines: params.lines,
+          defaultLines: contextLimits?.memoryGetDefaultLines ?? DEFAULT_MEMORY_READ_LINES,
+          maxChars: contextLimits?.memoryGetMaxChars,
+          suggestReadFallback: isDefaultMemoryPath(relPath),
+        });
+      }
+      // Non-daily files: use efficient streaming partial read.
       const requestedCount = Math.max(
         1,
         params.lines ?? contextLimits?.memoryGetDefaultLines ?? DEFAULT_MEMORY_READ_LINES,
@@ -1216,11 +1238,6 @@ export class QmdMemoryManager implements MemorySearchManager {
       if (partial.missing) {
         return { text: "", path: relPath };
       }
-      // TODO(#68367): partial reads of daily memory files still expose dreaming
-      // blocks.  Stripping here would shift line numbers relative to the raw
-      // file, which breaks callers that paginate with from/lines offsets.
-      // A future fix could read-then-strip the full file and re-slice, or
-      // introduce virtual line mapping.
       return buildMemoryReadResultFromSlice({
         selectedLines: partial.selectedLines,
         relPath,
