fix: align warning and action error classification

Tesla-20 · Tesla-20 · commit b1b49b056131 · 2026-03-27T07:04:38.000-04:00
Addresses chatgpt-codex-connector[bot] P2 review feedback:

The warning and action fields in buildMemorySearchUnavailableResult now use
the same error classification logic (resolveEmbeddingErrorKind). Previously,
warning used a regex that didn't include "rate limit", while action used
resolveEmbeddingErrorHint which does include it, causing inconsistent
diagnostics for "rate limit exceeded" errors.

Now both fields correctly classify rate limit errors as quota failures,
ensuring consistent messaging to users and callers.

No functional changes to the actual remediation logic - purely fixing the
internal consistency of warning text.
diff --git a/extensions/memory-core/src/tools.shared.ts b/extensions/memory-core/src/tools.shared.ts
@@ -166,7 +166,9 @@ function resolveEmbeddingErrorHint(error: string | undefined): string | undefine
 
 export function buildMemorySearchUnavailableResult(error: string | undefined) {
   const reason = (error ?? "memory search unavailable").trim() || "memory search unavailable";
-  const isQuotaError = /insufficient_quota|quota|429/.test(reason.toLowerCase());
+  // Use resolveEmbeddingErrorKind for consistent classification across warning and action
+  const kind = resolveEmbeddingErrorKind(reason);
+  const isQuotaError = kind === "quota";
   const warning = isQuotaError
     ? "Memory search is unavailable because the embedding provider quota is exhausted."
     : "Memory search is unavailable due to an embedding/provider error.";
