fix(line): remove redundant group:/room: prefix from buildPeerId (#21907)

damaozi · damaozi · commit b14538c0d243 · 2026-02-20T23:27:32.000+08:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,8 @@ Docs: https://docs.openclaw.ai
 
 ### Fixes
 
+- LINE: remove redundant `group:`/`room:` prefix from `buildPeerId` so peer-based binding routes match the raw group/room ID as documented. (#21907)
+
 - macOS/Build: default release packaging to `BUNDLE_ID=ai.openclaw.mac` in `scripts/package-mac-dist.sh`, so Sparkle feed URL is retained and auto-update no longer fails with an empty appcast feed. (#19750) thanks @loganprit.
 
 - Signal/Outbound: preserve case for Base64 group IDs during outbound target normalization so cross-context routing and policy checks no longer break when group IDs include uppercase characters. (#5578) Thanks @heyhudson.
diff --git a/src/line/bot-message-context.test.ts b/src/line/bot-message-context.test.ts
@@ -83,4 +83,78 @@ describe("buildLineMessageContext", () => {
     expect(context?.ctxPayload.OriginatingTo).toBe("line:group:group-2");
     expect(context?.ctxPayload.To).toBe("line:group:group-2");
   });
+
+  it("group peer binding matches raw groupId without prefix (#21907)", async () => {
+    const groupId = "Cc7e3bece1234567890abcdef";
+    const bindingCfg: OpenClawConfig = {
+      session: { store: storePath },
+      agents: {
+        list: [{ id: "main" }, { id: "line-group-agent" }],
+      },
+      bindings: [
+        {
+          agentId: "line-group-agent",
+          match: { channel: "line", peer: { kind: "group", id: groupId } },
+        },
+      ],
+    };
+
+    const event = {
+      type: "message",
+      message: { id: "msg-1", type: "text", text: "hello" },
+      replyToken: "reply-token",
+      timestamp: Date.now(),
+      source: { type: "group", groupId, userId: "user-1" },
+      mode: "active",
+      webhookEventId: "evt-1",
+      deliveryContext: { isRedelivery: false },
+    } as MessageEvent;
+
+    const context = await buildLineMessageContext({
+      event,
+      allMedia: [],
+      cfg: bindingCfg,
+      account,
+    });
+    expect(context).not.toBeNull();
+    expect(context!.route.agentId).toBe("line-group-agent");
+    expect(context!.route.matchedBy).toBe("binding.peer");
+  });
+
+  it("room peer binding matches raw roomId without prefix (#21907)", async () => {
+    const roomId = "Rr1234567890abcdef";
+    const bindingCfg: OpenClawConfig = {
+      session: { store: storePath },
+      agents: {
+        list: [{ id: "main" }, { id: "line-room-agent" }],
+      },
+      bindings: [
+        {
+          agentId: "line-room-agent",
+          match: { channel: "line", peer: { kind: "group", id: roomId } },
+        },
+      ],
+    };
+
+    const event = {
+      type: "message",
+      message: { id: "msg-2", type: "text", text: "hello" },
+      replyToken: "reply-token",
+      timestamp: Date.now(),
+      source: { type: "room", roomId, userId: "user-2" },
+      mode: "active",
+      webhookEventId: "evt-2",
+      deliveryContext: { isRedelivery: false },
+    } as MessageEvent;
+
+    const context = await buildLineMessageContext({
+      event,
+      allMedia: [],
+      cfg: bindingCfg,
+      account,
+    });
+    expect(context).not.toBeNull();
+    expect(context!.route.agentId).toBe("line-room-agent");
+    expect(context!.route.matchedBy).toBe("binding.peer");
+  });
 });
diff --git a/src/line/bot-message-context.ts b/src/line/bot-message-context.ts
@@ -51,10 +51,10 @@ export function getLineSourceInfo(source: EventSource): LineSourceInfo {
 
 function buildPeerId(source: EventSource): string {
   if (source.type === "group" && source.groupId) {
-    return `group:${source.groupId}`;
+    return source.groupId;
   }
   if (source.type === "room" && source.roomId) {
-    return `room:${source.roomId}`;
+    return source.roomId;
   }
   if (source.type === "user" && source.userId) {
     return source.userId;

Original file line number	Diff line number	Diff line change
`@@ -51,10 +51,10 @@ export function getLineSourceInfo(source: EventSource): LineSourceInfo {`
`51`	`51`
`52`	`52`	`function buildPeerId(source: EventSource): string {`
`53`	`53`	`if (source.type === "group" && source.groupId) {`
`54`		- return `group:${source.groupId}`;
	`54`	`+ return source.groupId;`
`55`	`55`	`}`
`56`	`56`	`if (source.type === "room" && source.roomId) {`
`57`		- return `room:${source.roomId}`;
	`57`	`+ return source.roomId;`
`58`	`58`	`}`
`59`	`59`	`if (source.type === "user" && source.userId) {`
`60`	`60`	`return source.userId;`