fix(qa): reject profile flags without qa profile

RomneyDa · RomneyDa · commit aea44c92f73a · 2026-06-14T17:57:17.000-07:00
diff --git a/extensions/qa-lab/src/cli.test.ts b/extensions/qa-lab/src/cli.test.ts
@@ -248,6 +248,53 @@ describe("qa cli registration", () => {
     expect(runQaLabSelfCheckCommand).not.toHaveBeenCalled();
   });
 
+  it.each([
+    ["--output-dir", [".artifacts/qa-e2e/smoke-ci"]],
+    ["--surface", ["agent-runtime-and-provider-execution"]],
+    ["--category", ["agent-runtime-and-provider-execution.agent-turn-execution"]],
+    ["--transport", ["qa-channel"]],
+    ["--provider-mode", ["mock-openai"]],
+    ["--model", ["openai/gpt-5.5"]],
+    ["--alt-model", ["anthropic/claude-sonnet-4-6"]],
+    ["--concurrency", ["2"]],
+    ["--allow-failures", []],
+    ["--fast", []],
+  ])("rejects qa run profile-only flag %s without --qa-profile", async (flag, values) => {
+    await expect(
+      program.parseAsync(["node", "openclaw", "qa", "run", flag, ...values]),
+    ).rejects.toThrow(`qa run ${flag} requires --qa-profile`);
+
+    expect(runQaLabSelfCheckCommand).not.toHaveBeenCalled();
+    expect(runQaProfileCommand).not.toHaveBeenCalled();
+  });
+
+  it("rejects an empty qa run --qa-profile instead of falling back to self-check", async () => {
+    await expect(
+      program.parseAsync(["node", "openclaw", "qa", "run", "--qa-profile", ""]),
+    ).rejects.toThrow("--qa-profile must not be empty.");
+
+    expect(runQaLabSelfCheckCommand).not.toHaveBeenCalled();
+    expect(runQaProfileCommand).not.toHaveBeenCalled();
+  });
+
+  it("rejects self-check output flags in qa run profile mode", async () => {
+    await expect(
+      program.parseAsync([
+        "node",
+        "openclaw",
+        "qa",
+        "run",
+        "--qa-profile",
+        "smoke-ci",
+        "--output",
+        ".artifacts/qa-self-check.md",
+      ]),
+    ).rejects.toThrow("qa run --output is only valid for the self-check mode");
+
+    expect(runQaLabSelfCheckCommand).not.toHaveBeenCalled();
+    expect(runQaProfileCommand).not.toHaveBeenCalled();
+  });
+
   it("routes mantis discord-smoke flags into the mantis runtime command", async () => {
     await program.parseAsync([
       "node",
diff --git a/extensions/qa-lab/src/cli.ts b/extensions/qa-lab/src/cli.ts
@@ -42,6 +42,21 @@ type QaRunCliOptions = QaLabSelfCheckCommandOptions &
     category?: QaProfileCommandOptions["category"];
   };
 
+const QA_RUN_PROFILE_ONLY_OPTIONS = [
+  { optionName: "outputDir", flag: "--output-dir" },
+  { optionName: "surface", flag: "--surface" },
+  { optionName: "category", flag: "--category" },
+  { optionName: "transport", flag: "--transport" },
+  { optionName: "providerMode", flag: "--provider-mode" },
+  { optionName: "model", flag: "--model" },
+  { optionName: "altModel", flag: "--alt-model" },
+  { optionName: "concurrency", flag: "--concurrency" },
+  { optionName: "allowFailures", flag: "--allow-failures" },
+  { optionName: "fast", flag: "--fast" },
+] as const;
+
+const QA_RUN_SELF_CHECK_ONLY_OPTIONS = [{ optionName: "output", flag: "--output" }] as const;
+
 type QaSuiteCliOptions = QaScenarioRunCliOptions & {
   runner?: QaSuiteCommandOptions["runner"];
   thinking?: QaSuiteCommandOptions["thinking"];
@@ -82,6 +97,43 @@ function parseQaCliPositiveIntegerOption(value: string, flag: string): number {
   return parsed;
 }
 
+function collectCliSuppliedQaRunFlags(
+  command: Command,
+  options: readonly { optionName: string; flag: string }[],
+): string[] {
+  return options
+    .filter((option) => command.getOptionValueSource(option.optionName) === "cli")
+    .map((option) => option.flag);
+}
+
+function formatFlagList(flags: readonly string[]): string {
+  return flags.length === 1 ? flags[0] : flags.join(", ");
+}
+
+function validateQaRunMode(opts: QaRunCliOptions, command: Command) {
+  const hasQaProfile = Boolean(opts.qaProfile?.trim());
+  if (command.getOptionValueSource("qaProfile") === "cli" && !hasQaProfile) {
+    throw new Error("--qa-profile must not be empty.");
+  }
+
+  if (hasQaProfile) {
+    const selfCheckFlags = collectCliSuppliedQaRunFlags(command, QA_RUN_SELF_CHECK_ONLY_OPTIONS);
+    if (selfCheckFlags.length > 0) {
+      throw new Error(
+        `qa run ${formatFlagList(selfCheckFlags)} is only valid for the self-check mode without --qa-profile.`,
+      );
+    }
+    return;
+  }
+
+  const profileFlags = collectCliSuppliedQaRunFlags(command, QA_RUN_PROFILE_ONLY_OPTIONS);
+  if (profileFlags.length > 0) {
+    throw new Error(
+      `qa run ${formatFlagList(profileFlags)} requires --qa-profile; without --qa-profile, qa run only executes the self-check.`,
+    );
+  }
+}
+
 async function runQaSelfCheck(opts: QaLabSelfCheckCommandOptions) {
   const runtime = await loadQaLabCliRuntime();
   await runtime.runQaLabSelfCheckCommand(opts);
@@ -329,7 +381,8 @@ export function registerQaLabCli(program: Command) {
       false,
     )
     .option("--fast", "Enable provider fast mode where supported", false)
-    .action(async (opts: QaRunCliOptions) => {
+    .action(async (opts: QaRunCliOptions, command: Command) => {
+      validateQaRunMode(opts, command);
       if (opts.qaProfile?.trim()) {
         await runQaProfile({
           repoRoot: opts.repoRoot,
