fix(agents): guard lean tool name reads

vincentkoc · vincentkoc · commit ae21ac4d47f0 · 2026-06-03T08:46:15.000+02:00
diff --git a/src/agents/local-model-lean.test.ts b/src/agents/local-model-lean.test.ts
@@ -36,6 +36,33 @@ describe("local model lean tool filtering", () => {
     ).toEqual(["read", "exec"]);
   });
 
+  it("omits unreadable tool names while lean filtering stays active", () => {
+    const cfg: OpenClawConfig = {
+      agents: {
+        defaults: {
+          experimental: {
+            localModelLean: true,
+          },
+        },
+      },
+    };
+    const readTool = { name: "read" } as AnyAgentTool;
+    const unreadableTool = {} as AnyAgentTool;
+    Object.defineProperty(unreadableTool, "name", {
+      get() {
+        throw new Error("local model lean tool name getter exploded");
+      },
+    });
+    const execTool = { name: "exec" } as AnyAgentTool;
+
+    expect(
+      filterLocalModelLeanTools({
+        tools: [readTool, unreadableTool, { name: "cron" } as AnyAgentTool, execTool],
+        config: cfg,
+      }),
+    ).toEqual([readTool, execTool]);
+  });
+
   it("keeps explicitly preserved tools when lean mode is enabled", () => {
     const cfg: OpenClawConfig = {
       agents: {
diff --git a/src/agents/local-model-lean.ts b/src/agents/local-model-lean.ts
@@ -17,6 +17,14 @@ function resolvePreservedLocalModelLeanToolNames(names?: Iterable<string>): Set<
   );
 }
 
+function readNormalizedLocalModelLeanToolName(tool: AnyAgentTool): string | undefined {
+  try {
+    return normalizeToolName(tool.name) || undefined;
+  } catch {
+    return undefined;
+  }
+}
+
 export function resolveLocalModelLeanPreserveToolNames(params?: {
   toolNames?: Iterable<string>;
   forceMessageTool?: boolean;
@@ -74,7 +82,10 @@ export function filterLocalModelLeanTools(params: {
   }
   const preservedToolNames = resolvePreservedLocalModelLeanToolNames(params.preserveToolNames);
   return params.tools.filter((tool) => {
-    const normalizedName = normalizeToolName(tool.name);
+    const normalizedName = readNormalizedLocalModelLeanToolName(tool);
+    if (!normalizedName) {
+      return false;
+    }
     return (
       preservedToolNames.has(normalizedName) ||
       !LOCAL_MODEL_LEAN_DENY_TOOL_NAMES.has(normalizedName)
