refactor: use isRecord() type guard for updatedInput, tighten test types

mmyzwl · claude · mmyzwl · commit adf8976b151c · 2026-07-01T00:13:46.000+08:00
- Replace unsafe `as Record&lt;string, unknown&gt;` type assertion with type-safe
  `isRecord(request.input) ? request.input : {}` guard in allow response
- Update test type annotations from `behavior: string` to literal `"allow"`
  and `updatedInput?: Record` to required `updatedInput: Record`

Co-Authored-By: Claude &lt;noreply@anthropic.com&gt;
diff --git a/src/agents/cli-runner.spawn.test.ts b/src/agents/cli-runner.spawn.test.ts
@@ -1961,7 +1961,7 @@ ${JSON.stringify({
       response: {
         subtype: string;
         request_id: string;
-        response: { behavior: string; updatedInput?: Record<string, unknown>; toolUseID?: string };
+        response: { behavior: "allow"; updatedInput: Record<string, unknown>; toolUseID?: string };
       };
     };
     expect(parsed.type).toBe("control_response");
@@ -2332,7 +2332,7 @@ ${JSON.stringify({
       response: {
         subtype: string;
         request_id: string;
-        response: { behavior: string; updatedInput?: Record<string, unknown>; toolUseID?: string };
+        response: { behavior: "allow"; updatedInput: Record<string, unknown>; toolUseID?: string };
       };
     };
     expect(parsed.response.response.updatedInput).toEqual({ command: "echo hi" });
@@ -2769,7 +2769,7 @@ ${JSON.stringify({
       response: {
         subtype: string;
         request_id: string;
-        response: { behavior: string; updatedInput?: Record<string, unknown>; toolUseID?: string };
+        response: { behavior: "allow"; updatedInput: Record<string, unknown>; toolUseID?: string };
       };
     };
     expect(parsed.response.response.updatedInput).toEqual({ command: "ls" });
diff --git a/src/agents/cli-runner/claude-live-session.ts b/src/agents/cli-runner/claude-live-session.ts
@@ -878,7 +878,7 @@ function handleClaudeLiveControlRequest(
       response: allowed
         ? {
             behavior: "allow",
-            updatedInput: (request.input ?? {}) as Record<string, unknown>,
+            updatedInput: isRecord(request.input) ? request.input : {},
             ...(toolUseId ? { toolUseID: toolUseId } : {}),
           }
         : {

Original file line number	Diff line number	Diff line change
`@@ -878,7 +878,7 @@ function handleClaudeLiveControlRequest(`
`878`	`878`	`response: allowed`
`879`	`879`	`? {`
`880`	`880`	`behavior: "allow",`
`881`		`- updatedInput: (request.input ?? {}) as Record<string, unknown>,`
	`881`	`+ updatedInput: isRecord(request.input) ? request.input : {},`
`882`	`882`	`...(toolUseId ? { toolUseID: toolUseId } : {}),`
`883`	`883`	`}`
`884`	`884`	`: {`