Skip to content

Commit adc576f

Browse files
committed
merge: refresh abort rejection fix against current main
2 parents a53c77e + f6653d1 commit adc576f

4,606 files changed

Lines changed: 258011 additions & 112357 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.agents/skills/autoreview/SKILL.md

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ Use when:
3636
- Tools are useful in review mode. Codex receives the validated bundle in an empty workspace so ignored files and linked-worktree metadata remain unreadable; web search stays available for dependency contracts and upstream docs.
3737
- Security perspective is always included, but it should not cripple legitimate functionality. Report security findings only when the change creates a concrete, actionable risk or removes an important safety check.
3838
- Reviewer subprocesses preserve engine authentication and non-credentialed proxy variables needed by headless or restricted-network environments while stripping process-injection, Git override, and credentialed proxy values.
39-
- Review bundles fail closed before engine invocation when tracked or untracked paths look sensitive, patch text looks secret-like, or a Git diff exceeds the bundle limit. Redact/split the change; never accept a truncated patch as complete review proof.
39+
- Review bundles fail closed before engine invocation when tracked or untracked paths look sensitive or patch text looks secret-like. Safe large diffs are scanned in full, sent as one pass while they fit the aggregate prompt limit, then partitioned into complete bounded passes without truncation.
4040
- For regression provenance, keep roles separate: blamed code author, blamed PR author, PR merger/committer, current PR author, and PR/date. If no blamed PR is traceable, use the blamed commit as the provenance: commit SHA, date, and author username. Do not guess a merger or frame missing PR metadata as a separate finding.
4141
- If the blamed PR was merged by `clawsweeper[bot]` or another automation, identify the human trigger when practical. Check timeline/comments first; if rate-limited, use gitcrawl/cache or public PR HTML. Look for maintainer commands such as `@clawsweeper automerge`, `/landpr`, or labels/status comments that armed automerge. Report `automerge triggered by @login`; if not found, say trigger unknown.
42-
- Do not invoke built-in `codex review`, nested reviewers, or reviewer panels from inside the review. The helper builds one bundle, calls one selected engine, validates one structured result, and stops.
42+
- Do not invoke built-in `codex review`, nested reviewers, or reviewer panels from inside the review. The helper builds one validated bundle, calls the selected engine once for normal inputs or once per complete bounded chunk for oversized inputs, validates the structured results, and stops.
4343
- Stop as soon as the helper exits 0 with no accepted/actionable findings. Do not run an extra review just to get a nicer "clean" line, a second opinion, or clearer closeout wording.
4444
- Treat the helper's successful exit plus absence of actionable findings as the clean review result, even if the underlying Codex CLI output is terse.
4545
- Multi-reviewer panels are opt-in only. Use them when explicitly requested or when risk justifies the extra spend; the main agent still verifies every accepted finding before fixing.
@@ -189,6 +189,29 @@ clean `main` against `origin/main` is usually an empty diff after push. For a
189189
small stack, review each commit explicitly or review the branch before merging
190190
with `--base`.
191191

192+
## Oversized Bundles
193+
194+
The helper scans the full patch before partitioning it. A safe bundle that fits
195+
the aggregate prompt limit remains one integrated review pass. Larger bundles
196+
are split at bundle sections and file boundaries where possible; an oversized
197+
single-file block is split at line boundaries with repeated file/hunk context
198+
and an absolute new- or old-file line offset. Untracked snapshots use
199+
injection-safe source-line records so continuation passes retain reportable
200+
locations. A single physical diff line split across passes also retains its
201+
original addition, deletion, or context marker.
202+
Every original bundle byte appears exactly once across the pass sequence, and
203+
all validated reports are merged before required-finding and exit-status checks.
204+
The helper caps one run at eight bounded passes so an unexpectedly huge branch
205+
cannot create unbounded model calls; split still-larger work into coherent review
206+
targets.
207+
208+
Chunking makes large-diff review usable, but it cannot give one model call every
209+
cross-file implementation detail. For architecture-heavy changes, still prefer
210+
a coherent branch or PR shape whose semantic decision surface fits one pass.
211+
Removing verified non-authoritative generated noise remains useful, but never
212+
drop lockfiles, generated clients, policies, manifests, schemas, or other
213+
independently semantic artifacts merely to shrink the review.
214+
192215
## Parallel Closeout
193216

194217
Format first if formatting can change line locations. Then it is OK to run tests and review in parallel:
@@ -386,6 +409,7 @@ The helper:
386409
- recognizes `--engine droid`, `copilot`, `cursor`, and `opencode` only to fail closed with isolation errors; runnable engines are `codex`, `claude`, and `pi`; default is `AUTOREVIEW_ENGINE` or `codex`
387410
- resolves bare `git`, `gh`, reviewer, and PowerShell shell commands from absolute `PATH` entries only, never from the reviewed checkout; explicit `--*-bin` paths are interpreted from the reviewed repository root when relative and accepted only when both the supplied path and resolved target stay outside the reviewed repository
388411
- use `--mode commit --commit <ref>` for already-committed work, especially clean `main` after landing
412+
- scans safe Git patches in full, reviews them in one pass up to the aggregate prompt limit, and automatically uses complete bounded passes above it
389413
- should be left in `--mode auto` or forced to `--mode branch` for PR/branch work; do not force `--mode local` after committing
390414
- writes only to stdout unless `--output`, `--json-output`, or live streamed engine stderr is set
391415
- supports `--dry-run`, `--parallel-tests`, `--parallel-tests-shell`, `--prompt`, repo-relative `--prompt-file`, repo-relative `--dataset`, `--no-tools`, `--no-web-search`, repeatable Codex-only safe model/response tuning with `--codex-config key=value`, Codex-only `--codex-speed fast|flex|default`, and commit refs

0 commit comments

Comments
 (0)