fix(mac): clean dSYM staging on zip failure

vincentkoc · vincentkoc · commit ad5d2cbc1bcb · 2026-06-20T19:07:04.000+02:00
diff --git a/scripts/package-mac-dist.sh b/scripts/package-mac-dist.sh
@@ -256,7 +256,10 @@ if [[ "$SKIP_DSYM" != "1" ]]; then
     fi
     echo "🧩 dSYM: $DSYM_ZIP"
     rm -f "$DSYM_ZIP"
-    ditto -c -k --keepParent "$TMP_DSYM" "$DSYM_ZIP"
+    if ! ditto -c -k --keepParent "$TMP_DSYM" "$DSYM_ZIP"; then
+      rm -rf "$TMP_DSYM"
+      exit 1
+    fi
     rm -rf "$TMP_DSYM"
   else
     echo "Error: dSYM not found (set SKIP_DSYM=1 to skip symbols)" >&2
diff --git a/test/scripts/package-mac-dist.test.ts b/test/scripts/package-mac-dist.test.ts
@@ -245,6 +245,8 @@ describe("package-mac-dist plist validation", () => {
     expect(dsymBlock).toContain("Error: missing DWARF binaries for dSYM merge");
     expect(dsymBlock).toContain("Error: dSYM not found");
     expect(dsymBlock).toContain("exit 1");
+    expect(dsymBlock).toContain('if ! ditto -c -k --keepParent "$TMP_DSYM" "$DSYM_ZIP"; then');
+    expect(dsymBlock).toContain('rm -rf "$TMP_DSYM"');
     expect(dsymBlock).not.toContain("WARN:");
     expect(dsymBlock).not.toContain("continuing");
   });
