fix(gateway): wrap aux-handler warn in arrow to preserve log binding

davidangularme · davidangularme · commit ab8378804205 · 2026-04-23T19:20:28.000+03:00
Greptile review feedback on #70676: the previous 'const warn = params.log.warn; logger: { warn }' shape detaches the method from its owning logger, so any implementation that relies on 'this' (or that gets rebound later on params.log) would mis-fire. Replace with an arrow-function wrapper that invokes params.log.warn through its owner each call.
diff --git a/src/gateway/server-aux-handlers.ts b/src/gateway/server-aux-handlers.ts
@@ -62,11 +62,10 @@ export function createGatewayAuxHandlers(params: {
         nextSharedGatewaySessionGeneration,
       );
       if (previousSharedGatewaySessionGeneration !== nextSharedGatewaySessionGeneration) {
-        const warn = params.log.warn;
         disconnectStaleSharedGatewayAuthClients({
           clients: params.clients,
           expectedGeneration: nextSharedGatewaySessionGeneration,
-          logger: warn ? { warn } : undefined,
+          logger: params.log.warn ? { warn: (m: string) => params.log.warn!(m) } : undefined,
         });
       }
       return { warningCount: prepared.warnings.length };
