fix(onboard): omit empty provider request settings

vincentkoc · vincentkoc · commit aad99747cd45 · 2026-07-08T17:26:29.000-07:00
diff --git a/src/commands/onboard-auth.config-shared.test.ts b/src/commands/onboard-auth.config-shared.test.ts
@@ -101,6 +101,34 @@ describe("onboard auth provider config merges", () => {
     expect(next.models?.providers?.other?.timeoutSeconds).toBe(300);
   });
 
+  it("omits empty provider request settings", () => {
+    const next = applyOnboardAuthAgentModelsAndProviders(
+      {
+        models: {
+          providers: {
+            custom: {
+              api: "openai-completions",
+              baseUrl: "https://old.example.com/v1",
+              models: [makeModel("model-a")],
+            },
+          },
+        },
+      },
+      {
+        agentModels,
+        providers: {
+          custom: {
+            api: "openai-completions",
+            baseUrl: "https://new.example.com/v1",
+            models: [makeModel("model-b")],
+          },
+        },
+      },
+    );
+
+    expect(next.models?.providers?.custom).not.toHaveProperty("request");
+  });
+
   it("preserves settings without resurrecting a non-canonical provider key", () => {
     const next = applyOnboardAuthAgentModelsAndProviders(
       {
diff --git a/src/plugin-sdk/provider-onboard.ts b/src/plugin-sdk/provider-onboard.ts
@@ -329,10 +329,15 @@ function mergeOnboardProviderConfigs(
       }
     }
     if (!("request" in providerConfig) || providerConfig.request) {
-      nextProvider.request = mergeOnboardProviderRequest(
+      const mergedRequest = mergeOnboardProviderRequest(
         existingProvider.request,
         providerConfig.request,
       );
+      if (mergedRequest) {
+        nextProvider.request = mergedRequest;
+      } else {
+        delete nextProvider.request;
+      }
     }
     merged[providerId] = nextProvider;
   }

Original file line number	Diff line number	Diff line change
`@@ -329,10 +329,15 @@ function mergeOnboardProviderConfigs(`
`329`	`329`	`}`
`330`	`330`	`}`
`331`	`331`	`if (!("request" in providerConfig) \|\| providerConfig.request) {`
`332`		`- nextProvider.request = mergeOnboardProviderRequest(`
	`332`	`+ const mergedRequest = mergeOnboardProviderRequest(`
`333`	`333`	`existingProvider.request,`
`334`	`334`	`providerConfig.request,`
`335`	`335`	`);`
	`336`	`+ if (mergedRequest) {`
	`337`	`+ nextProvider.request = mergedRequest;`
	`338`	`+ } else {`
	`339`	`+ delete nextProvider.request;`
	`340`	`+ }`
`336`	`341`	`}`
`337`	`342`	`merged[providerId] = nextProvider;`
`338`	`343`	`}`