fix(tooling): reject malformed tsdown watchdog limits

vincentkoc · vincentkoc · commit a86a1de8499f · 2026-06-02T23:43:09.000+02:00
diff --git a/scripts/tsdown-build.mjs b/scripts/tsdown-build.mjs
@@ -294,26 +294,34 @@ function findFatalUnresolvedImport(lines) {
   return null;
 }
 
-function parsePositiveInteger(value) {
+function parsePositiveIntegerEnv(value, name) {
   if (typeof value !== "string" || value.trim() === "") {
     return null;
   }
-  const parsed = Number(value);
-  if (!Number.isFinite(parsed) || parsed <= 0) {
-    return null;
+  const text = value.trim();
+  if (!/^\d+$/u.test(text)) {
+    throw new Error(`${name} must be a positive integer`);
   }
-  return Math.trunc(parsed);
+  const parsed = Number(text);
+  if (!Number.isSafeInteger(parsed) || parsed <= 0) {
+    throw new Error(`${name} must be a positive safe integer`);
+  }
+  return parsed;
 }
 
-function parseNonNegativeInteger(value) {
+function parseNonNegativeIntegerEnv(value, name) {
   if (typeof value !== "string" || value.trim() === "") {
     return null;
   }
-  const parsed = Number(value);
-  if (!Number.isFinite(parsed) || parsed < 0) {
-    return null;
+  const text = value.trim();
+  if (!/^\d+$/u.test(text)) {
+    throw new Error(`${name} must be a non-negative integer`);
   }
-  return Math.trunc(parsed);
+  const parsed = Number(text);
+  if (!Number.isSafeInteger(parsed)) {
+    throw new Error(`${name} must be a non-negative safe integer`);
+  }
+  return parsed;
 }
 
 function parseCgroupMemoryLimitBytes(value) {
@@ -582,9 +590,15 @@ export async function runTsdownBuildInvocation(invocation, params = {}) {
   const stderr = params.stderr ?? process.stderr;
   const env = params.env ?? process.env;
   const scanner = params.scanner ?? createTsdownOutputScanner();
-  const timeoutMs = parsePositiveInteger(env.OPENCLAW_TSDOWN_TIMEOUT_MS);
+  const timeoutMs = parsePositiveIntegerEnv(
+    env.OPENCLAW_TSDOWN_TIMEOUT_MS,
+    "OPENCLAW_TSDOWN_TIMEOUT_MS",
+  );
   const heartbeatMs =
-    parseNonNegativeInteger(env.OPENCLAW_TSDOWN_HEARTBEAT_MS) ?? DEFAULT_HEARTBEAT_MS;
+    parseNonNegativeIntegerEnv(
+      env.OPENCLAW_TSDOWN_HEARTBEAT_MS,
+      "OPENCLAW_TSDOWN_HEARTBEAT_MS",
+    ) ?? DEFAULT_HEARTBEAT_MS;
   let timedOut = false;
   let settled = false;
   let lastOutputAt = Date.now();
diff --git a/test/scripts/tsdown-build.test.ts b/test/scripts/tsdown-build.test.ts
@@ -535,6 +535,52 @@ describe("runTsdownBuildInvocation", () => {
     expect(output.chunks.join("")).toContain("stdout-ok");
   });
 
+  it("rejects malformed OPENCLAW_TSDOWN_TIMEOUT_MS values", async () => {
+    const invocation = {
+      command: process.execPath,
+      args: ["-e", "process.exit(0)"],
+      options: {
+        stdio: ["ignore", "pipe", "pipe"],
+        shell: false,
+        env: process.env,
+      },
+    };
+
+    for (const value of ["1.5", "1e3", "10ms", "0"]) {
+      await expect(
+        runTsdownBuildInvocation(invocation, {
+          env: {
+            ...process.env,
+            OPENCLAW_TSDOWN_TIMEOUT_MS: value,
+          },
+        }),
+      ).rejects.toThrow("OPENCLAW_TSDOWN_TIMEOUT_MS must be");
+    }
+  });
+
+  it("rejects malformed OPENCLAW_TSDOWN_HEARTBEAT_MS values", async () => {
+    const invocation = {
+      command: process.execPath,
+      args: ["-e", "process.exit(0)"],
+      options: {
+        stdio: ["ignore", "pipe", "pipe"],
+        shell: false,
+        env: process.env,
+      },
+    };
+
+    for (const value of ["1.5", "1e3", "10ms", "-1"]) {
+      await expect(
+        runTsdownBuildInvocation(invocation, {
+          env: {
+            ...process.env,
+            OPENCLAW_TSDOWN_HEARTBEAT_MS: value,
+          },
+        }),
+      ).rejects.toThrow("OPENCLAW_TSDOWN_HEARTBEAT_MS must be");
+    }
+  });
+
   it("terminates the child when OPENCLAW_TSDOWN_TIMEOUT_MS elapses", async () => {
     const output = createWriteSink();
     const result = await runTsdownBuildInvocation(
