fix(browser): ignore blank Windows install roots

LZY3538 · LZY3538 · commit a64c13a42c41 · 2026-07-19T15:19:17.000+08:00
diff --git a/extensions/browser/src/browser/chrome.default-browser.test.ts b/extensions/browser/src/browser/chrome.default-browser.test.ts
@@ -1,5 +1,5 @@
 // Browser tests cover chromeefault browser plugin behavior.
-import { beforeEach, describe, expect, it, vi } from "vitest";
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 
 vi.mock("node:child_process", async () => {
   const { mockNodeBuiltinModule } = await import("openclaw/plugin-sdk/test-node-mocks");
@@ -72,6 +72,10 @@ describe("browser default executable detection", () => {
     vi.mocked(os.homedir).mockReturnValue("/Users/test");
   });
 
+  afterEach(() => {
+    vi.unstubAllEnvs();
+  });
+
   it("prefers default Chromium browser on macOS", () => {
     mockMacDefaultBrowser("com.google.Chrome", "/Applications/Google Chrome.app");
     mockChromeExecutableExists();
@@ -214,6 +218,25 @@ describe("browser default executable detection", () => {
     expect(exe?.path.toLowerCase()).toMatch(/\\google\\chrome\\application\\chrome\.exe$/);
   });
 
+  it("uses standard Windows install roots when ProgramFiles overrides are blank", () => {
+    vi.stubEnv("ProgramFiles", "   ");
+    vi.stubEnv("ProgramFiles(x86)", "");
+    vi.mocked(fs.existsSync).mockImplementation(
+      (candidate) =>
+        String(candidate) === "C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe",
+    );
+
+    expect(
+      resolveBrowserExecutableForPlatform(
+        {} as Parameters<typeof resolveBrowserExecutableForPlatform>[0],
+        "win32",
+      ),
+    ).toEqual({
+      kind: "chrome",
+      path: "C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe",
+    });
+  });
+
   it("canonicalizes an explicitly configured Opera launcher", () => {
     const installDir = "C:\\Users\\test\\AppData\\Local\\Programs\\Opera";
     const launcher = `${installDir}\\launcher.exe`;
diff --git a/extensions/browser/src/browser/chrome.executables.ts b/extensions/browser/src/browser/chrome.executables.ts
@@ -666,10 +666,11 @@ function findGoogleChromeExecutableLinux(): BrowserExecutable | null {
 
 /** Find the best Chromium-family executable on Windows. */
 function findChromeExecutableWindows(): BrowserExecutable | null {
-  const localAppData = process.env.LOCALAPPDATA ?? "";
-  const programFiles = process.env.ProgramFiles ?? "C:\\Program Files";
+  const localAppData = normalizeOptionalString(process.env.LOCALAPPDATA) ?? "";
+  const programFiles = normalizeOptionalString(process.env.ProgramFiles) ?? "C:\\Program Files";
   // Must use bracket notation: variable name contains parentheses.
-  const programFilesX86 = process.env["ProgramFiles(x86)"] ?? "C:\\Program Files (x86)";
+  const programFilesX86 =
+    normalizeOptionalString(process.env["ProgramFiles(x86)"]) ?? "C:\\Program Files (x86)";
   const joinWin = path.win32.join;
   const candidates: Array<BrowserExecutable> = [];
 
@@ -736,9 +737,10 @@ function findChromeExecutableWindows(): BrowserExecutable | null {
 }
 
 function findGoogleChromeExecutableWindows(): BrowserExecutable | null {
-  const localAppData = process.env.LOCALAPPDATA ?? "";
-  const programFiles = process.env.ProgramFiles ?? "C:\\Program Files";
-  const programFilesX86 = process.env["ProgramFiles(x86)"] ?? "C:\\Program Files (x86)";
+  const localAppData = normalizeOptionalString(process.env.LOCALAPPDATA) ?? "";
+  const programFiles = normalizeOptionalString(process.env.ProgramFiles) ?? "C:\\Program Files";
+  const programFilesX86 =
+    normalizeOptionalString(process.env["ProgramFiles(x86)"]) ?? "C:\\Program Files (x86)";
   const joinWin = path.win32.join;
   const candidates: string[] = [];
 
