test: tighten cron timer task ledger assertions

shakkernerd · shakkernerd · commit a5ed3f28c162 · 2026-05-11T05:10:38.000+01:00
diff --git a/src/cron/service/timer.test.ts b/src/cron/service/timer.test.ts
@@ -80,11 +80,23 @@ describe("cron service timer seam coverage", () => {
     expect(job.state.runningAtMs).toBeUndefined();
     expect(job.state.nextRunAtMs).toBe(now + 60_000);
     const task = findTaskByRunId(`cron:main-heartbeat-job:${now}`);
-    expect(task).toMatchObject({
-      runtime: "cron",
-      status: "succeeded",
-      endedAt: now,
-    });
+    if (!task) {
+      throw new Error("expected cron task ledger record");
+    }
+    expect(task.runtime).toBe("cron");
+    expect(task.sourceId).toBe("main-heartbeat-job");
+    expect(task.ownerKey).toBe("");
+    expect(task.scopeKind).toBe("system");
+    expect(task.childSessionKey).toBe("agent:main:main");
+    expect(task.runId).toBe(`cron:main-heartbeat-job:${now}`);
+    expect(task.label).toBe("main heartbeat job");
+    expect(task.task).toBe("main heartbeat job");
+    expect(task.status).toBe("succeeded");
+    expect(task.deliveryStatus).toBe("not_applicable");
+    expect(task.notifyPolicy).toBe("silent");
+    expect(task.startedAt).toBe(now);
+    expect(task.lastEventAt).toBe(now);
+    expect(task.endedAt).toBe(now);
     expect(task?.cleanupAfter).toBe(now + 7 * 24 * 60 * 60_000);
 
     const delays = timeoutSpy.mock.calls
@@ -101,6 +113,7 @@ describe("cron service timer seam coverage", () => {
     const now = Date.parse("2026-03-23T12:00:00.000Z");
     const enqueueSystemEvent = vi.fn();
     const requestHeartbeat = vi.fn();
+    const ledgerError = new Error("disk full");
 
     await writeCronStoreSnapshot({
       storePath,
@@ -110,7 +123,7 @@ describe("cron service timer seam coverage", () => {
     const createTaskRecordSpy = vi
       .spyOn(detachedTaskRuntime, "createRunningTaskRun")
       .mockImplementation(() => {
-        throw new Error("disk full");
+        throw ledgerError;
       });
 
     const state = createCronServiceState({
@@ -126,7 +139,7 @@ describe("cron service timer seam coverage", () => {
     await onTimer(state);
 
     expect(logger.warn).toHaveBeenCalledWith(
-      expect.objectContaining({ jobId: "main-heartbeat-job" }),
+      { jobId: "main-heartbeat-job", error: ledgerError },
       "cron: failed to create task ledger record",
     );
     expect(enqueueSystemEvent).toHaveBeenCalledWith("heartbeat seam tick", {
