Skip to content

Commit a594d2c

Browse files
committed
fix(channels): remove unusable post-final progress override
1 parent c92f366 commit a594d2c

2 files changed

Lines changed: 2 additions & 27 deletions

File tree

src/channels/progress-draft-compositor.test.ts

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -148,28 +148,6 @@ describe("createChannelProgressDraftCompositor", () => {
148148
expect(update).not.toHaveBeenCalled();
149149
});
150150

151-
it("allows explicit post-final progress notices", async () => {
152-
const update = vi.fn();
153-
const progress = createChannelProgressDraftCompositor({
154-
entry: { streaming: { mode: "progress", progress: { label: "Shelling" } } },
155-
mode: "progress",
156-
active: true,
157-
seed: "test",
158-
update,
159-
});
160-
161-
progress.markFinalReplyDelivered();
162-
163-
expect(await progress.pushToolProgress("🛠️ Hidden", { startImmediately: true })).toBe(false);
164-
expect(
165-
await progress.pushToolProgress("💨Fast: auto-on", {
166-
startImmediately: true,
167-
allowAfterFinal: true,
168-
}),
169-
).toBe(true);
170-
expect(update).toHaveBeenCalledWith("Shelling\n\n💨Fast: auto-on", { flush: true });
171-
});
172-
173151
it("composes reasoning deltas with tool progress", async () => {
174152
const update = vi.fn();
175153
const progress = createChannelProgressDraftCompositor({

src/channels/progress-draft-compositor.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,9 @@ export function createChannelProgressDraftCompositor(params: {
119119

120120
const noteProgress = async (
121121
line?: ChannelProgressDraftCompositorLine,
122-
options?: { toolName?: string; startImmediately?: boolean; allowAfterFinal?: boolean },
122+
options?: { toolName?: string; startImmediately?: boolean },
123123
) => {
124-
if (
125-
!params.active ||
126-
((finalReplyStarted || finalReplyDelivered) && !options?.allowAfterFinal)
127-
) {
124+
if (!params.active || finalReplyStarted || finalReplyDelivered) {
128125
return false;
129126
}
130127
if (options?.toolName !== undefined && !isChannelProgressDraftWorkToolName(options.toolName)) {

0 commit comments

Comments
 (0)