fix(qa): require boundary entry shim outputs

vincentkoc · vincentkoc · commit a590f7f69014 · 2026-06-20T17:25:11.000+02:00
diff --git a/scripts/prepare-extension-package-boundary-artifacts.mjs b/scripts/prepare-extension-package-boundary-artifacts.mjs
@@ -5,6 +5,7 @@ import fs from "node:fs";
 import path, { resolve } from "node:path";
 import { isLocalCheckEnabled } from "./lib/local-heavy-check-runtime.mjs";
 import { parsePositiveInt } from "./lib/numeric-options.mjs";
+import { pluginSdkEntrypoints, publicPluginSdkEntrypoints } from "./lib/plugin-sdk-entries.mjs";
 
 const repoRoot = resolve(import.meta.dirname, "..");
 const runTsgoScript = path.join(repoRoot, "scripts/run-tsgo.mjs");
@@ -241,6 +242,22 @@ const ENTRY_SHIMS_INPUTS = [
   "scripts/lib/plugin-sdk-entrypoints.json",
   "scripts/lib/plugin-sdk-entries.mjs",
 ];
+const ENTRY_SHIM_RUNTIME_OUTPUTS = ["dist/plugin-sdk/webhook-path.js"];
+
+/**
+ * Lists entry-shim artifacts written by scripts/write-plugin-sdk-entry-dts.ts.
+ */
+export function resolveBoundaryEntryShimRequiredOutputs(env = process.env) {
+  const entries =
+    env.OPENCLAW_BUILD_PRIVATE_QA === "1" ? pluginSdkEntrypoints : publicPluginSdkEntrypoints;
+  return [
+    ...entries.flatMap((entry) => [
+      `dist/plugin-sdk/${entry}.d.ts`,
+      `packages/plugin-sdk/dist/src/plugin-sdk/${entry}.d.ts`,
+    ]),
+    ...ENTRY_SHIM_RUNTIME_OUTPUTS,
+  ].toSorted((a, b) => a.localeCompare(b));
+}
 
 function isRelevantTypeInput(filePath) {
   const basename = path.basename(filePath);
@@ -621,7 +638,10 @@ async function main(argv = process.argv.slice(2)) {
         "dist/plugin-sdk/.tsbuildinfo",
         "packages/plugin-sdk/dist/.tsbuildinfo",
       ],
-      outputPaths: ["dist/plugin-sdk/.boundary-entry-shims.stamp"],
+      outputPaths: [
+        "dist/plugin-sdk/.boundary-entry-shims.stamp",
+        ...resolveBoundaryEntryShimRequiredOutputs(),
+      ],
     });
     const qaChannelDtsFresh =
       isArtifactSetFresh({
diff --git a/test/scripts/prepare-extension-package-boundary-artifacts.test.ts b/test/scripts/prepare-extension-package-boundary-artifacts.test.ts
@@ -12,6 +12,7 @@ import {
   createPrefixedOutputWriter,
   isArtifactSetFresh,
   parseMode,
+  resolveBoundaryEntryShimRequiredOutputs,
   resolveBoundaryRootShimsTimeoutMs,
   runNodeStep,
   runNodeSteps,
@@ -404,6 +405,67 @@ describe("prepare-extension-package-boundary-artifacts", () => {
     ).toBe(false);
   });
 
+  it("requires generated entry-shim outputs in addition to the freshness stamp", () => {
+    const rootDir = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-boundary-entry-shims-"));
+    tempRoots.add(rootDir);
+    const inputPath = path.join(rootDir, "scripts", "write-plugin-sdk-entry-dts.ts");
+    const stampPath = path.join(rootDir, "dist", "plugin-sdk", ".boundary-entry-shims.stamp");
+    const rootDtsPath = path.join(rootDir, "dist", "plugin-sdk", "index.d.ts");
+    const packageDtsPath = path.join(
+      rootDir,
+      "packages",
+      "plugin-sdk",
+      "dist",
+      "src",
+      "plugin-sdk",
+      "index.d.ts",
+    );
+
+    fs.mkdirSync(path.dirname(inputPath), { recursive: true });
+    fs.mkdirSync(path.dirname(stampPath), { recursive: true });
+    fs.mkdirSync(path.dirname(rootDtsPath), { recursive: true });
+    fs.mkdirSync(path.dirname(packageDtsPath), { recursive: true });
+    fs.writeFileSync(inputPath, "export {};\n", "utf8");
+    fs.writeFileSync(stampPath, "ok\n", "utf8");
+    fs.writeFileSync(rootDtsPath, "export {};\n", "utf8");
+    fs.writeFileSync(packageDtsPath, "export {};\n", "utf8");
+
+    fs.utimesSync(inputPath, new Date(1_000), new Date(1_000));
+    fs.utimesSync(stampPath, new Date(2_000), new Date(2_000));
+    fs.utimesSync(rootDtsPath, new Date(2_000), new Date(2_000));
+    fs.utimesSync(packageDtsPath, new Date(2_000), new Date(2_000));
+
+    expect(
+      isArtifactSetFresh({
+        rootDir,
+        inputPaths: ["scripts/write-plugin-sdk-entry-dts.ts"],
+        outputPaths: [
+          "dist/plugin-sdk/.boundary-entry-shims.stamp",
+          "dist/plugin-sdk/index.d.ts",
+          "packages/plugin-sdk/dist/src/plugin-sdk/index.d.ts",
+        ],
+      }),
+    ).toBe(true);
+
+    fs.rmSync(packageDtsPath);
+
+    expect(
+      isArtifactSetFresh({
+        rootDir,
+        inputPaths: ["scripts/write-plugin-sdk-entry-dts.ts"],
+        outputPaths: [
+          "dist/plugin-sdk/.boundary-entry-shims.stamp",
+          "dist/plugin-sdk/index.d.ts",
+          "packages/plugin-sdk/dist/src/plugin-sdk/index.d.ts",
+        ],
+      }),
+    ).toBe(false);
+    expect(resolveBoundaryEntryShimRequiredOutputs({})).toContain("dist/plugin-sdk/index.d.ts");
+    expect(resolveBoundaryEntryShimRequiredOutputs({})).toContain(
+      "packages/plugin-sdk/dist/src/plugin-sdk/index.d.ts",
+    );
+  });
+
   it("parses prep mode and rejects unknown values", () => {
     expect(parseMode([])).toBe("all");
     expect(parseMode(["--mode=package-boundary"])).toBe("package-boundary");
