fix(feishu): stop typing-indicator log spam and stuck emoji on message-not-found

lbo728 · lbo728 · commit a1889d1da38f · 2026-02-26T21:44:30.000+09:00
- Remove internal console.log from addTypingIndicator/removeTypingIndicator; errors now propagate so callers handle them via the structured onStartError / onStopError paths instead of raw console output. - Add isFeishuMessageNotFoundError() helper that detects Feishu error code 231003 ("The message is not found, maybe not exist or deleted"). - In reply-dispatcher, introduce typingDisabled flag: the first time start() receives a 231003 error the flag is set and all subsequent keepalive ticks are skipped, eliminating the 3-second log spam seen in #27418. - Guard start() so it skips when typingState.reactionId is already set. Previously the keepalive overwrote typingState with null on every tick (because addTypingIndicator failed silently), causing removeTypingIndicator to find no reactionId and leaving the Typing emoji permanently on the user's message. Fixes #27418
diff --git a/extensions/feishu/src/reply-dispatcher.ts b/extensions/feishu/src/reply-dispatcher.ts
@@ -14,7 +14,12 @@ import { getFeishuRuntime } from "./runtime.js";
 import { sendMarkdownCardFeishu, sendMessageFeishu } from "./send.js";
 import { FeishuStreamingSession } from "./streaming-card.js";
 import { resolveReceiveIdType } from "./targets.js";
-import { addTypingIndicator, removeTypingIndicator, type TypingIndicatorState } from "./typing.js";
+import {
+  addTypingIndicator,
+  isFeishuMessageNotFoundError,
+  removeTypingIndicator,
+  type TypingIndicatorState,
+} from "./typing.js";
 
 /** Detect if text contains markdown elements that benefit from card rendering */
 function shouldUseCard(text: string): boolean {
@@ -38,9 +43,19 @@ export function createFeishuReplyDispatcher(params: CreateFeishuReplyDispatcherP
   const prefixContext = createReplyPrefixContext({ cfg, agentId });
 
   let typingState: TypingIndicatorState | null = null;
+  // Set to true when the message is no longer available (Feishu error 231003).
+  // Once disabled, all subsequent typing-start attempts are skipped so the
+  // keepalive loop does not produce repeated 400 errors in the logs.
+  let typingDisabled = false;
   const typingCallbacks = createTypingCallbacks({
     start: async () => {
-      if (!replyToMessageId) {
+      if (!replyToMessageId || typingDisabled) {
+        return;
+      }
+      // Skip if we already hold a valid reaction ID — the keepalive should
+      // not try to add duplicate reactions on every tick, which would
+      // overwrite `typingState` with null and leave the emoji stuck.
+      if (typingState?.reactionId) {
         return;
       }
       typingState = await addTypingIndicator({ cfg, messageId: replyToMessageId, accountId });
@@ -49,16 +64,24 @@ export function createFeishuReplyDispatcher(params: CreateFeishuReplyDispatcherP
       if (!typingState) {
         return;
       }
-      await removeTypingIndicator({ cfg, state: typingState, accountId });
+      const stateToRemove = typingState;
       typingState = null;
+      await removeTypingIndicator({ cfg, state: stateToRemove, accountId });
     },
-    onStartError: (err) =>
+    onStartError: (err) => {
+      if (isFeishuMessageNotFoundError(err)) {
+        // Message was deleted or expired — disable the typing indicator for
+        // this session to prevent log spam on every keepalive tick.
+        typingDisabled = true;
+        return;
+      }
       logTypingFailure({
         log: (message) => params.runtime.log?.(message),
         channel: "feishu",
         action: "start",
         error: err,
-      }),
+      });
+    },
     onStopError: (err) =>
       logTypingFailure({
         log: (message) => params.runtime.log?.(message),
diff --git a/extensions/feishu/src/typing.test.ts b/extensions/feishu/src/typing.test.ts
@@ -0,0 +1,36 @@
+import { describe, expect, it } from "vitest";
+import { isFeishuMessageNotFoundError } from "./typing.js";
+
+describe("isFeishuMessageNotFoundError", () => {
+  it("returns true for Axios error with code 231003 in response.data", () => {
+    const err = { response: { data: { code: 231003, msg: "The message is not found" } } };
+    expect(isFeishuMessageNotFoundError(err)).toBe(true);
+  });
+
+  it("returns true for error with code 231003 at top level", () => {
+    const err = { code: 231003, message: "not found" };
+    expect(isFeishuMessageNotFoundError(err)).toBe(true);
+  });
+
+  it("returns false for other Feishu error codes", () => {
+    const err = { response: { data: { code: 99991672, msg: "Permission denied" } } };
+    expect(isFeishuMessageNotFoundError(err)).toBe(false);
+  });
+
+  it("returns false for non-object errors", () => {
+    expect(isFeishuMessageNotFoundError(null)).toBe(false);
+    expect(isFeishuMessageNotFoundError(undefined)).toBe(false);
+    expect(isFeishuMessageNotFoundError("some string error")).toBe(false);
+    expect(isFeishuMessageNotFoundError(42)).toBe(false);
+  });
+
+  it("returns false for errors without a code field", () => {
+    const err = new Error("network error");
+    expect(isFeishuMessageNotFoundError(err)).toBe(false);
+  });
+
+  it("returns false for errors with response.data but no code", () => {
+    const err = { response: { data: { msg: "unknown error" } } };
+    expect(isFeishuMessageNotFoundError(err)).toBe(false);
+  });
+});
diff --git a/extensions/feishu/src/typing.ts b/extensions/feishu/src/typing.ts
@@ -7,13 +7,35 @@ import { createFeishuClient } from "./client.js";
 // Full list: https://github.com/go-lark/lark/blob/main/emoji.go
 const TYPING_EMOJI = "Typing"; // Typing indicator emoji
 
+/** Feishu error code: the target message was not found (deleted or expired). */
+const FEISHU_ERROR_MESSAGE_NOT_FOUND = 231003;
+
 export type TypingIndicatorState = {
   messageId: string;
   reactionId: string | null;
 };
 
 /**
- * Add a typing indicator (reaction) to a message
+ * Returns true when the Feishu API error indicates the message no longer
+ * exists (code 231003). In that case the caller should stop retrying.
+ */
+export function isFeishuMessageNotFoundError(err: unknown): boolean {
+  if (!err || typeof err !== "object") return false;
+  // Feishu SDK wraps Axios errors: err.response.data carries the API error body.
+  const data = (err as { response?: { data?: unknown } }).response?.data;
+  if (data && typeof data === "object") {
+    const code = (data as { code?: number }).code;
+    if (code === FEISHU_ERROR_MESSAGE_NOT_FOUND) return true;
+  }
+  // Some SDK versions also expose the code at the top level.
+  if ((err as { code?: number }).code === FEISHU_ERROR_MESSAGE_NOT_FOUND) return true;
+  return false;
+}
+
+/**
+ * Add a typing indicator (reaction) to a message.
+ * Throws on failure so callers can decide how to handle it (e.g. disable
+ * retries when the message no longer exists).
  */
 export async function addTypingIndicator(params: {
   cfg: ClawdbotConfig;
@@ -28,26 +50,21 @@ export async function addTypingIndicator(params: {
 
   const client = createFeishuClient(account);
 
-  try {
-    const response = await client.im.messageReaction.create({
-      path: { message_id: messageId },
-      data: {
-        reaction_type: { emoji_type: TYPING_EMOJI },
-      },
-    });
+  const response = await client.im.messageReaction.create({
+    path: { message_id: messageId },
+    data: {
+      reaction_type: { emoji_type: TYPING_EMOJI },
+    },
+  });
 
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any -- SDK response type
-    const reactionId = (response as any)?.data?.reaction_id ?? null;
-    return { messageId, reactionId };
-  } catch (err) {
-    // Silently fail - typing indicator is not critical
-    console.log(`[feishu] failed to add typing indicator: ${err}`);
-    return { messageId, reactionId: null };
-  }
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any -- SDK response type
+  const reactionId = (response as any)?.data?.reaction_id ?? null;
+  return { messageId, reactionId };
 }
 
 /**
- * Remove a typing indicator (reaction) from a message
+ * Remove a typing indicator (reaction) from a message.
+ * Throws on failure so callers can log via the structured error path.
  */
 export async function removeTypingIndicator(params: {
   cfg: ClawdbotConfig;
@@ -66,15 +83,10 @@ export async function removeTypingIndicator(params: {
 
   const client = createFeishuClient(account);
 
-  try {
-    await client.im.messageReaction.delete({
-      path: {
-        message_id: state.messageId,
-        reaction_id: state.reactionId,
-      },
-    });
-  } catch (err) {
-    // Silently fail - cleanup is not critical
-    console.log(`[feishu] failed to remove typing indicator: ${err}`);
-  }
+  await client.im.messageReaction.delete({
+    path: {
+      message_id: state.messageId,
+      reaction_id: state.reactionId,
+    },
+  });
 }
