fix(workspaces): satisfy pubsub lint and export gates

Eva · Eva · commit 9fc036d9884f · 2026-07-13T17:56:37.000+07:00
diff --git a/ui/src/components/workspace-custom-widget.test.ts b/ui/src/components/workspace-custom-widget.test.ts
@@ -359,17 +359,22 @@ describe("attachWidgetBridge parent-brokered pub/sub", () => {
     const filter = connected({ id: "filter", tabSlug: "a", bus });
     const chart = connected({ id: "chart", tabSlug: "a", bus });
     const otherTab = connected({ id: "other", tabSlug: "b", bus });
-    chart.childPort.postMessage({ v: 1, type: "workspace:subscribe", channel: "selection" });
-    otherTab.childPort.postMessage({ v: 1, type: "workspace:subscribe", channel: "selection" });
+    chart.childPort.postMessage({ v: 1, type: "workspace:subscribe", channel: "selection" }, []);
+    otherTab.childPort.postMessage({ v: 1, type: "workspace:subscribe", channel: "selection" }, []);
     // MessagePorts are ordered individually, not across distinct ports. Let both
     // subscriptions reach the parent before publishing from the third port.
-    await new Promise((resolve) => setTimeout(resolve, 0));
-    filter.childPort.postMessage({
-      v: 1,
-      type: "workspace:publish",
-      channel: "selection",
-      payload: { region: "eu" },
+    await new Promise<void>((resolve) => {
+      setTimeout(resolve, 0);
     });
+    filter.childPort.postMessage(
+      {
+        v: 1,
+        type: "workspace:publish",
+        channel: "selection",
+        payload: { region: "eu" },
+      },
+      [],
+    );
 
     await vi.waitFor(() => expect(chart.posts).toHaveLength(1));
     expect(chart.posts[0]).toEqual({
@@ -391,19 +396,26 @@ describe("attachWidgetBridge parent-brokered pub/sub", () => {
     const bus = createWorkspaceWidgetBus();
     const publisher = connected({ id: "publisher", tabSlug: "removed", bus });
     const subscriber = connected({ id: "subscriber", tabSlug: "removed", bus });
-    subscriber.childPort.postMessage({ v: 1, type: "workspace:subscribe", channel: "updates" });
-    await new Promise((resolve) => setTimeout(resolve, 0));
+    subscriber.childPort.postMessage({ v: 1, type: "workspace:subscribe", channel: "updates" }, []);
+    await new Promise<void>((resolve) => {
+      setTimeout(resolve, 0);
+    });
 
     subscriber.detach();
-    publisher.childPort.postMessage({
-      v: 1,
-      type: "workspace:publish",
-      channel: "updates",
-      payload: 1,
-    });
+    publisher.childPort.postMessage(
+      {
+        v: 1,
+        type: "workspace:publish",
+        channel: "updates",
+        payload: 1,
+      },
+      [],
+    );
     bus.retainTabs(new Set());
     bus.dispose();
-    await new Promise((resolve) => setTimeout(resolve, 0));
+    await new Promise<void>((resolve) => {
+      setTimeout(resolve, 0);
+    });
 
     expect(subscriber.posts).toHaveLength(0);
     publisher.detach();
diff --git a/ui/src/lib/workspace/bridge.test.ts b/ui/src/lib/workspace/bridge.test.ts
@@ -2,10 +2,8 @@ import { beforeEach, describe, expect, it, vi } from "vitest";
 import {
   createWidgetBridge,
   isWellFormedInbound,
-  resetBusRateStatesForTest,
   resetPromptRateStatesForTest,
   type WidgetBridgeDeps,
-  type WidgetBusBridge,
   type WidgetErrorCode,
   type WidgetOutboundMessage,
 } from "./bridge.ts";
@@ -14,7 +12,6 @@ import type { WidgetManifestView } from "./types.ts";
 beforeEach(() => {
   // Rate-limit state is module-level (keyed by widget name); reset between tests.
   resetPromptRateStatesForTest();
-  resetBusRateStatesForTest();
 });
 
 function manifest(overrides?: Partial<WidgetManifestView>): WidgetManifestView {
@@ -245,7 +242,7 @@ describe("pub/sub capability + limits + cleanup", () => {
   function fakeBus() {
     const published: Array<{ channel: string; payload: unknown }> = [];
     const subscriptions = new Map<string, (channel: string, payload: unknown) => void>();
-    const bus: WidgetBusBridge = {
+    const bus: NonNullable<WidgetBridgeDeps["bus"]> = {
       publish: (channel, payload) => published.push({ channel, payload }),
       subscribe: (channel, deliver) => {
         subscriptions.set(channel, deliver);
diff --git a/ui/src/lib/workspace/bridge.ts b/ui/src/lib/workspace/bridge.ts
@@ -50,7 +50,7 @@ export type WidgetOutboundMessage =
   | { v: 1; type: "workspace:message"; channel: string; payload: unknown }
   | { v: 1; type: "workspace:error"; requestId?: string; code: WidgetErrorCode; message: string };
 
-export type WidgetBusBridge = {
+type WidgetBusBridge = {
   publish: (channel: string, payload: unknown) => void;
   subscribe: (channel: string, deliver: (channel: string, payload: unknown) => void) => () => void;
 };
@@ -124,6 +124,7 @@ function getPromptRateState(widgetName: string): PromptRateState {
 /** Test-only: reset all persisted rate-limit budgets. */
 export function resetPromptRateStatesForTest(): void {
   promptRateStates.clear();
+  busRateStates.clear();
 }
 
 type BusRateState = { timestamps: number[] };
@@ -138,11 +139,6 @@ function getBusRateState(widgetName: string): BusRateState {
   return state;
 }
 
-/** Test-only: reset all persisted pub/sub rate-limit budgets. */
-export function resetBusRateStatesForTest(): void {
-  busRateStates.clear();
-}
-
 function isStrictJsonValue(root: unknown): boolean {
   const ancestors = new Set<object>();
   const stack: Array<{ value: unknown; exit?: boolean }> = [{ value: root }];
diff --git a/ui/src/lib/workspace/bus.ts b/ui/src/lib/workspace/bus.ts
@@ -1,6 +1,6 @@
 /** Parent-owned, in-memory pub/sub for custom widgets in one Workspaces view. */
 
-export type WorkspaceWidgetBusConnection = {
+type WorkspaceWidgetBusConnection = {
   publish: (channel: string, payload: unknown) => number;
   subscribe: (channel: string, deliver: (channel: string, payload: unknown) => void) => () => void;
   dispose: () => void;
