Skip to content

Commit 9e0d358

Browse files
committed
refactor: simplify runtime conversions
1 parent 37b91be commit 9e0d358

50 files changed

Lines changed: 80 additions & 98 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

src/agents/anthropic-transport-stream.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -777,7 +777,7 @@ export function createAnthropicMessagesTransportStreamFn(): StreamFn {
777777
delta?.type === "signature_delta" &&
778778
typeof delta.signature === "string"
779779
) {
780-
block.thinkingSignature = `${String(block.thinkingSignature ?? "")}${delta.signature}`;
780+
block.thinkingSignature = `${block.thinkingSignature ?? ""}${delta.signature}`;
781781
}
782782
continue;
783783
}

src/agents/pi-embedded-runner/compact.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -646,9 +646,7 @@ export async function compactEmbeddedPiSessionDirect(
646646
if (promptCapabilities.length > 0) {
647647
runtimeCapabilities ??= [];
648648
const seenCapabilities = new Set(
649-
runtimeCapabilities
650-
.map((cap) => normalizeOptionalLowercaseString(String(cap)))
651-
.filter(Boolean),
649+
runtimeCapabilities.map((cap) => normalizeOptionalLowercaseString(cap)).filter(Boolean),
652650
);
653651
for (const capability of promptCapabilities) {
654652
const normalizedCapability = normalizeOptionalLowercaseString(capability);

src/agents/pi-embedded-runner/run/attempt.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -611,9 +611,7 @@ export async function runEmbeddedAttempt(
611611
if (promptCapabilities.length > 0) {
612612
runtimeCapabilities ??= [];
613613
const seenCapabilities = new Set(
614-
runtimeCapabilities
615-
.map((cap) => normalizeOptionalLowercaseString(String(cap)))
616-
.filter(Boolean),
614+
runtimeCapabilities.map((cap) => normalizeOptionalLowercaseString(cap)).filter(Boolean),
617615
);
618616
for (const capability of promptCapabilities) {
619617
const normalizedCapability = normalizeOptionalLowercaseString(capability);

src/agents/pi-hooks/context-pruning/tools.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { compileGlobPatterns, matchesAnyGlobPattern } from "../../glob-pattern.j
33
import type { ContextPruningToolMatch } from "./settings.js";
44

55
function normalizeGlob(value: string) {
6-
return normalizeLowercaseStringOrEmpty(String(value ?? ""));
6+
return normalizeLowercaseStringOrEmpty(value ?? "");
77
}
88

99
export function makeToolPrunablePredicate(

src/auto-reply/fallback-state.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@ export type FallbackNoticeState = Pick<
1515
>;
1616

1717
function truncateFallbackReasonPart(value: string, max = FALLBACK_REASON_PART_MAX): string {
18-
const text = String(value ?? "")
19-
.replace(/\s+/g, " ")
20-
.trim();
18+
const text = value.replace(/\s+/g, " ").trim();
2119
if (text.length <= max) {
2220
return text;
2321
}

src/auto-reply/reply/agent-runner-utils.ts

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ export function buildThreadingToolContext(params: {
104104
}
105105

106106
export const isBunFetchSocketError = (message?: string) =>
107-
Boolean(message && BUN_FETCH_SOCKET_ERROR_RE.test(message));
107+
message ? BUN_FETCH_SOCKET_ERROR_RE.test(message) : false;
108108

109109
export const formatBunFetchSocketError = (message: string) => {
110110
const trimmed = message.trim();
@@ -121,15 +121,13 @@ export const resolveEnforceFinalTag = (
121121
provider: string,
122122
model = run.model,
123123
) =>
124-
Boolean(
125-
(run.skipProviderRuntimeHints ? false : undefined) ??
126-
(run.enforceFinalTag ||
127-
isReasoningTagProvider(provider, {
128-
config: run.config,
129-
workspaceDir: run.workspaceDir,
130-
modelId: model,
131-
})),
132-
);
124+
(run.skipProviderRuntimeHints ? false : undefined) ??
125+
(run.enforceFinalTag ||
126+
isReasoningTagProvider(provider, {
127+
config: run.config,
128+
workspaceDir: run.workspaceDir,
129+
modelId: model,
130+
}));
133131

134132
export function resolveModelFallbackOptions(run: FollowupRun["run"]) {
135133
const config = run.config;

src/auto-reply/reply/block-reply-pipeline.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ export function createBlockReplyPipeline(params: {
241241
enqueue,
242242
flush,
243243
stop,
244-
hasBuffered: () => Boolean(coalescer?.hasBuffered() || bufferedPayloads.length > 0),
244+
hasBuffered: () => coalescer?.hasBuffered() || bufferedPayloads.length > 0,
245245
didStream: () => didStream,
246246
isAborted: () => aborted,
247247
hasSentPayload: (payload) => {

src/auto-reply/reply/reply-elevated.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ function resolveAllowFromFormatter(params: {
4646
accountId: params.accountId,
4747
allowFrom: values,
4848
})
49-
.map((entry) => normalizeOptionalString(String(entry)) ?? "")
49+
.map((entry) => normalizeOptionalString(entry) ?? "")
5050
.filter(Boolean);
5151
}
5252

src/auto-reply/status.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ export function buildStatusMessage(args: StatusArgs): string {
467467
initialFallbackState.active &&
468468
normalizeLowercaseStringOrEmpty(runtimeModelRaw) ===
469469
normalizeLowercaseStringOrEmpty(
470-
normalizeOptionalString(String(entry?.fallbackNoticeActiveModel ?? "")) ?? "",
470+
normalizeOptionalString(entry?.fallbackNoticeActiveModel ?? "") ?? "",
471471
);
472472
const runtimeMatchesSelectedModel =
473473
normalizeLowercaseStringOrEmpty(runtimeModelRaw) ===

src/canvas-host/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ export async function startCanvasHost(opts: CanvasHostServerOpts): Promise<Canva
465465

466466
const bindHost = normalizeOptionalString(opts.listenHost) || "127.0.0.1";
467467
const server: Server = http.createServer((req, res) => {
468-
if (lowercasePreservingWhitespace(String(req.headers.upgrade ?? "")) === "websocket") {
468+
if (lowercasePreservingWhitespace(req.headers.upgrade ?? "") === "websocket") {
469469
return;
470470
}
471471
void (async () => {

0 commit comments

Comments
 (0)