fix: roll rounded durations into seconds

qingminglong · qingminglong · commit 9e069731128b · 2026-07-04T23:23:48.000+08:00
diff --git a/src/infra/format-time/format-duration.ts b/src/infra/format-time/format-duration.ts
@@ -33,8 +33,9 @@ export function formatDurationPrecise(
   if (!Number.isFinite(ms)) {
     return "unknown";
   }
-  if (ms < 1000) {
-    return `${Math.max(0, Math.round(ms))}ms`;
+  const roundedMs = Math.max(0, Math.round(ms));
+  if (roundedMs < 1000) {
+    return `${roundedMs}ms`;
   }
   return formatDurationSeconds(ms, {
     decimals: options.decimals ?? 2,
@@ -55,8 +56,9 @@ export function formatDurationCompact(
   if (ms == null || !Number.isFinite(ms) || ms <= 0) {
     return undefined;
   }
-  if (ms < 1000) {
-    return `${Math.round(ms)}ms`;
+  const roundedMs = Math.round(ms);
+  if (roundedMs < 1000) {
+    return `${roundedMs}ms`;
   }
   const sep = options?.spaced ? " " : "";
   const totalSeconds = Math.round(ms / 1000);
@@ -85,8 +87,9 @@ export function formatDurationHuman(ms?: number | null, fallback = "n/a"): strin
   if (ms == null || !Number.isFinite(ms) || ms < 0) {
     return fallback;
   }
-  if (ms < 1000) {
-    return `${Math.round(ms)}ms`;
+  const roundedMs = Math.round(ms);
+  if (roundedMs < 1000) {
+    return `${roundedMs}ms`;
   }
   const sec = Math.round(ms / 1000);
   if (sec < 60) {
diff --git a/src/infra/format-time/format-time.test.ts b/src/infra/format-time/format-time.test.ts
@@ -34,6 +34,7 @@ describe("format-duration", () => {
       expectFormatterCases(formatDurationCompact, [
         { input: 500, expected: "500ms" },
         { input: 999, expected: "999ms" },
+        { input: 999.6, expected: "1s" },
         { input: 1000, expected: "1s" },
         { input: 45000, expected: "45s" },
         { input: 59000, expected: "59s" },
@@ -71,6 +72,7 @@ describe("format-duration", () => {
     it("formats single-unit outputs and day threshold behavior", () => {
       expectFormatterCases(formatDurationHuman, [
         { input: 500, expected: "500ms" },
+        { input: 999.6, expected: "1s" },
         { input: 5000, expected: "5s" },
         { input: 180000, expected: "3m" },
         { input: 7200000, expected: "2h" },
@@ -88,7 +90,7 @@ describe("format-duration", () => {
       { input: 999, expected: "999ms" },
       { input: -1, expected: "0ms" },
       { input: -500, expected: "0ms" },
-      { input: 999.6, expected: "1000ms" },
+      { input: 999.6, expected: "1s" },
       { input: 1000, expected: "1s" },
       { input: 1500, expected: "1.5s" },
       { input: 1234, expected: "1.23s" },

Original file line number	Diff line number	Diff line change
`@@ -33,8 +33,9 @@ export function formatDurationPrecise(`
`33`	`33`	`if (!Number.isFinite(ms)) {`
`34`	`34`	`return "unknown";`
`35`	`35`	`}`
`36`		`- if (ms < 1000) {`
`37`		- return `${Math.max(0, Math.round(ms))}ms`;
	`36`	`+ const roundedMs = Math.max(0, Math.round(ms));`
	`37`	`+ if (roundedMs < 1000) {`
	`38`	+ return `${roundedMs}ms`;
`38`	`39`	`}`
`39`	`40`	`return formatDurationSeconds(ms, {`
`40`	`41`	`decimals: options.decimals ?? 2,`
`@@ -55,8 +56,9 @@ export function formatDurationCompact(`
`55`	`56`	`if (ms == null \|\| !Number.isFinite(ms) \|\| ms <= 0) {`
`56`	`57`	`return undefined;`
`57`	`58`	`}`
`58`		`- if (ms < 1000) {`
`59`		- return `${Math.round(ms)}ms`;
	`59`	`+ const roundedMs = Math.round(ms);`
	`60`	`+ if (roundedMs < 1000) {`
	`61`	+ return `${roundedMs}ms`;
`60`	`62`	`}`
`61`	`63`	`const sep = options?.spaced ? " " : "";`
`62`	`64`	`const totalSeconds = Math.round(ms / 1000);`
`@@ -85,8 +87,9 @@ export function formatDurationHuman(ms?: number \| null, fallback = "n/a"): strin`
`85`	`87`	`if (ms == null \|\| !Number.isFinite(ms) \|\| ms < 0) {`
`86`	`88`	`return fallback;`
`87`	`89`	`}`
`88`		`- if (ms < 1000) {`
`89`		- return `${Math.round(ms)}ms`;
	`90`	`+ const roundedMs = Math.round(ms);`
	`91`	`+ if (roundedMs < 1000) {`
	`92`	+ return `${roundedMs}ms`;
`90`	`93`	`}`
`91`	`94`	`const sec = Math.round(ms / 1000);`
`92`	`95`	`if (sec < 60) {`