fix(nostr): clear relay publish timers to prevent leaks and unhandled rejections

Bortlesboat · claude · Bortlesboat · commit 9de9afdcf83d · 2026-03-08T06:52:28.000-04:00
publishProfileEvent() uses Promise.race with a setTimeout-based timeout
promise per relay.  When pool.publish() wins the race, the pending
setTimeout fires later and rejects a promise nobody is listening to,
causing an unhandled promise rejection in strict Node environments.

Similarly, importProfileFromRelays() creates both an overall timeout
timer and per-relay subscription cleanup timers that continue running
even when all relays respond before the deadline.

Store timer handles and clear them in finally blocks so timers are
always cleaned up regardless of which side wins the race.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/extensions/nostr/src/nostr-profile-import.ts b/extensions/nostr/src/nostr-profile-import.ts
@@ -111,10 +111,14 @@ export async function importProfileFromRelays(
     const events: Array<{ event: Event; relay: string }> = [];
 
     // Create timeout promise
+    let overallTimer: ReturnType<typeof setTimeout> | undefined;
     const timeoutPromise = new Promise<void>((resolve) => {
-      setTimeout(resolve, timeoutMs);
+      overallTimer = setTimeout(resolve, timeoutMs);
     });
 
+    // Track per-relay cleanup timers so they can be cleared early
+    const subTimers: ReturnType<typeof setTimeout>[] = [];
+
     // Create subscription promise
     const subscriptionPromise = new Promise<void>((resolve) => {
       let completed = 0;
@@ -151,14 +155,22 @@ export async function importProfileFromRelays(
         );
 
         // Clean up subscription after timeout
-        setTimeout(() => {
+        const subTimer = setTimeout(() => {
           sub.close();
         }, timeoutMs);
+        subTimers.push(subTimer);
       }
     });
 
     // Wait for either all relays to respond or timeout
-    await Promise.race([subscriptionPromise, timeoutPromise]);
+    try {
+      await Promise.race([subscriptionPromise, timeoutPromise]);
+    } finally {
+      clearTimeout(overallTimer);
+      for (const t of subTimers) {
+        clearTimeout(t);
+      }
+    }
 
     // No events found
     if (events.length === 0) {
diff --git a/extensions/nostr/src/nostr-profile.ts b/extensions/nostr/src/nostr-profile.ts
@@ -177,9 +177,10 @@ export async function publishProfileEvent(
 
   // Publish to each relay in parallel with timeout
   const publishPromises = relays.map(async (relay) => {
+    let timer: ReturnType<typeof setTimeout> | undefined;
     try {
       const timeoutPromise = new Promise<never>((_, reject) => {
-        setTimeout(() => reject(new Error("timeout")), RELAY_PUBLISH_TIMEOUT_MS);
+        timer = setTimeout(() => reject(new Error("timeout")), RELAY_PUBLISH_TIMEOUT_MS);
       });
 
       // oxlint-disable-next-line typescript/no-floating-promises
@@ -189,6 +190,8 @@ export async function publishProfileEvent(
     } catch (err) {
       const errorMessage = err instanceof Error ? err.message : String(err);
       failures.push({ relay, error: errorMessage });
+    } finally {
+      clearTimeout(timer);
     }
   });
 
