fix(trajectory): tighten test types for partial skill entries

lukeboyett · claude · lukeboyett · commit 9d8e173017da · 2026-05-20T13:12:26.000-04:00
CI check-test-types was failing on src/trajectory/metadata.test.ts because
tsgo:test is stricter than local pnpm check. Rejected sourceInfo: {} and
bare 'undefined' assignments against typed SourceInfo / string fields.

Fill sourceInfo with a real SourceInfo shape for the valid 'alpha' entry,
cast the intentionally-partial entries to ResolvedSkillEntry via an
'as unknown as' bridge so the intent (simulating a symlink-escape reject
leaking through) stays explicit without weakening the type on the valid
branch.

Tests: 6 passed (unchanged). tsgo:core:test clean.

Co-Authored-By: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/src/trajectory/metadata.test.ts b/src/trajectory/metadata.test.ts
@@ -1,4 +1,5 @@
 import { afterEach, describe, expect, it, vi } from "vitest";
+import type { SkillSnapshot } from "../agents/skills.js";
 import { REDACTED_SENTINEL } from "../config/redact-snapshot.js";
 import {
   redactPathForSupport,
@@ -7,6 +8,8 @@ import {
 import { createEmptyPluginRegistry } from "../plugins/registry-empty.js";
 import { resetPluginRuntimeStateForTest, setActivePluginRegistry } from "../plugins/runtime.js";
 
+type ResolvedSkillEntry = NonNullable<SkillSnapshot["resolvedSkills"]>[number];
+
 const loadPluginManifestRegistry = vi.hoisted(() => vi.fn(() => ({ plugins: [] })));
 
 vi.mock("../infra/git-commit.js", () => ({
@@ -194,18 +197,24 @@ describe("trajectory metadata", () => {
             filePath: "/tmp/workspace/skills/alpha/SKILL.md",
             baseDir: "/tmp/workspace/skills/alpha",
             source: "workspace",
-            sourceInfo: {},
+            sourceInfo: {
+              path: "/tmp/workspace/skills/alpha/SKILL.md",
+              source: "workspace",
+              scope: "project",
+              origin: "top-level",
+              baseDir: "/tmp/workspace/skills/alpha",
+            },
             disableModelInvocation: false,
           },
           {
-            name: undefined as unknown as string,
+            name: undefined,
             description: undefined,
-            filePath: undefined as unknown as string,
-            baseDir: undefined as unknown as string,
+            filePath: undefined,
+            baseDir: undefined,
             source: "workspace",
             sourceInfo: undefined,
             disableModelInvocation: false,
-          },
+          } as unknown as ResolvedSkillEntry,
         ],
       },
     });
@@ -225,14 +234,14 @@ describe("trajectory metadata", () => {
         skills: [{ name: "fallback-skill" }],
         resolvedSkills: [
           {
-            name: undefined as unknown as string,
+            name: undefined,
             description: undefined,
-            filePath: undefined as unknown as string,
-            baseDir: undefined as unknown as string,
+            filePath: undefined,
+            baseDir: undefined,
             source: "workspace",
             sourceInfo: undefined,
             disableModelInvocation: false,
-          },
+          } as unknown as ResolvedSkillEntry,
         ],
       },
     });
