fix: skip timeout compaction when run was aborted by user

lykeion-dev · lykeion-dev · commit 9c503bb6c01a · 2026-05-12T03:46:09.000+09:00
When the user presses the stop button in the Control UI, the model
request times out. Previously, if context token usage exceeded 65%,
the timeout compaction mechanism would fire even though the run was
intentionally aborted — causing unnecessary compaction at an
inappropriate time.

Add !aborted check to the timeout compaction condition so that
user-initiated stops skip compaction entirely.
diff --git a/src/agents/pi-embedded-runner/run.timeout-triggered-compaction.test.ts b/src/agents/pi-embedded-runner/run.timeout-triggered-compaction.test.ts
@@ -365,7 +365,7 @@ describe("timeout-triggered compaction", () => {
     expect(result.payloads?.[0]?.text).toContain("timed out");
   });
 
-  it("still attempts compaction for timed-out attempts that set aborted", async () => {
+  it("skips timeout compaction when run was aborted by user", async () => {
     mockedRunEmbeddedAttempt.mockResolvedValueOnce(
       makeAttemptResult({
         timedOut: true,
@@ -375,20 +375,13 @@ describe("timeout-triggered compaction", () => {
         } as never,
       }),
     );
-    mockedCompactDirect.mockResolvedValueOnce(
-      makeCompactionSuccess({
-        summary: "timeout recovery compaction",
-        tokensBefore: 180000,
-        tokensAfter: 90000,
-      }),
-    );
-    mockedRunEmbeddedAttempt.mockResolvedValueOnce(makeAttemptResult({ promptError: null }));
 
     const result = await runEmbeddedPiAgent(overflowBaseRunParams);
 
-    expect(mockedCompactDirect).toHaveBeenCalledTimes(1);
-    expect(mockedRunEmbeddedAttempt).toHaveBeenCalledTimes(2);
-    expect(result.meta.error).toBeUndefined();
+    // Timeout compaction should NOT fire for intentionally aborted runs
+    expect(mockedCompactDirect).not.toHaveBeenCalled();
+    expect(result.payloads?.[0]?.isError).toBe(true);
+    expect(result.payloads?.[0]?.text).toContain("timed out");
   });
 
   it("does not attempt compaction when timedOutDuringCompaction is true", async () => {
@@ -531,7 +524,6 @@ describe("timeout-triggered compaction", () => {
       .mockResolvedValueOnce(
         makeAttemptResult({
           timedOut: true,
-          aborted: true,
           lastAssistant: {
             usage: { input: 150000 },
           } as never,
@@ -541,7 +533,6 @@ describe("timeout-triggered compaction", () => {
       .mockResolvedValueOnce(
         makeAttemptResult({
           timedOut: true,
-          aborted: true,
           lastAssistant: {
             usage: { input: 150000 },
           } as never,
@@ -582,7 +573,6 @@ describe("timeout-triggered compaction", () => {
       .mockResolvedValueOnce(
         makeAttemptResult({
           timedOut: true,
-          aborted: true,
           lastAssistant: {
             usage: { input: 150000 },
           } as never,
@@ -592,7 +582,6 @@ describe("timeout-triggered compaction", () => {
       .mockResolvedValueOnce(
         makeAttemptResult({
           timedOut: true,
-          aborted: true,
           lastAssistant: {
             usage: { input: 150000 },
           } as never,
diff --git a/src/agents/pi-embedded-runner/run.ts b/src/agents/pi-embedded-runner/run.ts
@@ -1557,7 +1557,7 @@ export async function runEmbeddedPiAgent(
           // ── Timeout-triggered compaction ──────────────────────────────────
           // When the LLM times out with high context usage, compact before
           // retrying to break the death spiral of repeated timeouts.
-          if (timedOut && !timedOutDuringCompaction && !timedOutDuringToolExecution) {
+          if (timedOut && !aborted && !timedOutDuringCompaction && !timedOutDuringToolExecution) {
             // Only consider prompt-side tokens here. API totals include output
             // tokens, which can make a long generation look like high context
             // pressure even when the prompt itself was small.
