fix(telegram): gate malformed-body recovery by HTTP status (4xx non-recoverable)

miorbnli · claude · miorbnli · commit 9b7e9322e841 · 2026-07-08T11:54:09.000+08:00
ClawSweeper flagged that the malformed-json snippet is too broad: a 4xx
response (bad token, apiRoot misconfig) with a non-JSON body would match
the snippet and retry indefinitely instead of surfacing as a fatal polling
error.

Split the fetchJson catch: 4xx client errors produce a message without
"malformed json", so the polling loop treats them as non-recoverable
(fatal). Server/transient statuses (5xx, 2xx) keep the recoverable path
(backoff retry).

Add 4xx regression test.

Co-Authored-By: Claude &lt;noreply@anthropic.com&gt;
diff --git a/extensions/telegram/src/network-errors.test.ts b/extensions/telegram/src/network-errors.test.ts
@@ -155,6 +155,23 @@ describe("isRecoverableTelegramNetworkError", () => {
     expect(isRecoverableTelegramNetworkError(err, { context: "send" })).toBe(false);
   });
 
+  it("treats 4xx ingress-worker malformed-JSON errors as non-recoverable (client error)", () => {
+    // 4xx client errors (bad token, apiRoot misconfig, etc.) must NOT match
+    // the "malformed json" snippet — polling should surface them as fatal
+    // rather than retrying indefinitely.
+    const clientErr = Object.assign(
+      new Error("Telegram getUpdates returned unparseable body (HTTP 401)"),
+      { statusCode: 401 },
+    );
+    expect(isRecoverableTelegramNetworkError(clientErr, { context: "polling" })).toBe(false);
+    // 5xx still treat as recoverable (regression guard for the non-4xx branch)
+    const serverErr = Object.assign(
+      new Error("Telegram getUpdates returned malformed JSON (HTTP 503)"),
+      { statusCode: 503 },
+    );
+    expect(isRecoverableTelegramNetworkError(serverErr, { context: "polling" })).toBe(true);
+  });
+
   it("treats delete/react/edit/action (idempotent) contexts like polling, not send", () => {
     const undiciSnippetErr = new Error("Undici: socket failure");
     // delete, react, edit, and action are idempotent or non-message operations;
