fix(outbound): ignore media sends without delivery identity

Zeng-wen · Zeng-wen · commit 9b1590c09488 · 2026-06-14T09:39:42.000+08:00
diff --git a/src/infra/outbound/deliver.test.ts b/src/infra/outbound/deliver.test.ts
@@ -2180,6 +2180,48 @@ describe("deliverOutboundPayloads", () => {
     expect(sendMediaOptions?.accountId).toBeUndefined();
   });
 
+  it("suppresses plugin media sends when the adapter returns no delivery identity", async () => {
+    const sendMedia = vi.fn().mockResolvedValue({ channel: "matrix", messageId: "" });
+    const payloadOutcomes: unknown[] = [];
+    setActivePluginRegistry(
+      createTestRegistry([
+        {
+          pluginId: "matrix",
+          source: "test",
+          plugin: createOutboundTestPlugin({
+            id: "matrix",
+            outbound: {
+              deliveryMode: "direct",
+              sendText: vi.fn().mockResolvedValue({ channel: "matrix", messageId: "text-1" }),
+              sendMedia,
+            },
+          }),
+        },
+      ]),
+    );
+
+    const results = await deliverOutboundPayloads({
+      cfg: {},
+      channel: "matrix",
+      to: "!explicit:example",
+      payloads: [{ text: "voice caption", mediaUrl: "file:///tmp/cron-tts.mp3" }],
+      skipQueue: true,
+      onPayloadDeliveryOutcome: (outcome) => {
+        payloadOutcomes.push(outcome);
+      },
+    });
+
+    expect(sendMedia).toHaveBeenCalledTimes(1);
+    expect(results).toStrictEqual([]);
+    expect(payloadOutcomes).toStrictEqual([
+      {
+        index: 0,
+        status: "suppressed",
+        reason: "adapter_returned_no_identity",
+      },
+    ]);
+  });
+
   it("forwards audioAsVoice through generic plugin media delivery", async () => {
     const sendMedia = vi.fn(async () => ({
       channel: "matrix" as const,
diff --git a/src/infra/outbound/deliver.ts b/src/infra/outbound/deliver.ts
@@ -1891,10 +1891,14 @@ async function deliverOutboundPayloadsCore(
               unit.overrides,
             )
           : await deliveryHandler.sendMedia(unit.caption ?? "", unit.mediaUrl, unit.overrides);
+        if (!hasDeliveryResultIdentity(delivery)) {
+          continue;
+        }
         results.push(delivery);
         firstMessageId ??= delivery.messageId;
         lastMessageId = delivery.messageId;
       }
+      const deliveredResults = results.slice(beforeCount);
       await maybePinDeliveredMessage({
         handler: deliveryHandler,
         payload: effectivePayload,
@@ -1906,9 +1910,8 @@ async function deliverOutboundPayloadsCore(
         handler: deliveryHandler,
         payload: effectivePayload,
         target: deliveryTarget,
-        results: results.slice(beforeCount),
+        results: deliveredResults,
       });
-      const deliveredResults = results.slice(beforeCount);
       if (deliveredResults.length > 0) {
         recordPayloadOutcome({
           index: payloadIndex,
@@ -1924,9 +1927,9 @@ async function deliverOutboundPayloadsCore(
           }),
         );
       }
-      completeDeliveryDiagnostics(results.length - beforeCount);
+      completeDeliveryDiagnostics(deliveredResults.length);
       emitMessageSent({
-        success: true,
+        success: deliveredResults.length > 0,
         content: payloadSummary.hookContent ?? payloadSummary.text,
         messageId: lastMessageId,
       });
