Skip to content

Commit 992a770

Browse files
committed
ACPX: fix CI config fixtures and secret allowlists
Add the required mcpServers field to ResolvedAcpxPluginConfig test fixtures and mark the remaining test-only provider credential literals as allowlisted false positives for detect-secrets.
1 parent d0f8389 commit 992a770

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

extensions/acpx/src/runtime-internals/test-fixtures.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,7 @@ export async function createMockRuntimeFixture(params?: {
306306
nonInteractivePermissions: "fail",
307307
strictWindowsCmdWrapper: true,
308308
queueOwnerTtlSeconds: params?.queueOwnerTtlSeconds ?? 0.1,
309+
mcpServers: {},
309310
};
310311

311312
return {

extensions/acpx/src/runtime.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ beforeAll(async () => {
2525
nonInteractivePermissions: "fail",
2626
strictWindowsCmdWrapper: true,
2727
queueOwnerTtlSeconds: 0.1,
28+
mcpServers: {},
2829
},
2930
{ logger: NOOP_LOGGER },
3031
);

src/acp/client.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,8 @@ describe("resolveAcpClientSpawnEnv", () => {
136136

137137
it("preserves provider auth env vars for explicit custom ACP servers", () => {
138138
const env = resolveAcpClientSpawnEnv({
139-
OPENAI_API_KEY: "openai-secret",
140-
GITHUB_TOKEN: "gh-secret",
139+
OPENAI_API_KEY: "openai-secret", // pragma: allowlist secret
140+
GITHUB_TOKEN: "gh-secret", // pragma: allowlist secret
141141
HF_TOKEN: "hf-secret",
142142
OPENCLAW_API_KEY: "keep-me",
143143
});

0 commit comments

Comments
 (0)